You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/11/14 03:42:43 UTC

[GitHub] [rocketmq] Erik1288 opened a new pull request, #5521: [ISSUE #5516] Support sending a bound of sub-requests IN ONE RPC, especially for data-streaming-related RPCs like sending, consuming and managing consumer offsets.

Erik1288 opened a new pull request, #5521:
URL: https://github.com/apache/rocketmq/pull/5521

   **Make sure set the target branch to `develop`**
   
   ## What is the purpose of the change
   Support sending a bound of sub-requests IN ONE RPC, especially for data-streaming-related RPCs like sending, consuming and managing consumer offsets.
   
   ## Brief changelog
   Details are available on #5516 .
   详细的设计请查看 #5516 .
   
   ## Verifying this change
   
   Pass the UTs.
   
   PS. 此版本的代码能清晰表达 Batch-Protocol 的意图和实现,但是是基于 7 月份的 Develop 分支,最新的代码由于工作原因还没有完成。社区的同学有兴趣可以 Review 下这个想法,也可以在此基础上做迭代开发。
   
   Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
   
   - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] zhouxinyu commented on pull request #5521: [ISSUE #5516] Support sending a bound of sub-requests IN ONE RPC, especially for data-streaming-related RPCs like sending, consuming and managing consumer offsets.

Posted by GitBox <gi...@apache.org>.
zhouxinyu commented on PR #5521:
URL: https://github.com/apache/rocketmq/pull/5521#issuecomment-1316281580

   Hi, @Erik1288, this is a big feature, we'd better start a discussion in the mailing list through a RIP.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ISSUE #5516] Support sending a bound of sub-requests IN ONE RPC, especially for data-streaming-related RPCs like sending, consuming and managing consumer offsets. [rocketmq]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #5521: [ISSUE #5516] Support sending a bound of sub-requests IN ONE RPC, especially for data-streaming-related RPCs like sending, consuming and managing consumer offsets.
URL: https://github.com/apache/rocketmq/pull/5521


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ISSUE #5516] Support sending a bound of sub-requests IN ONE RPC, especially for data-streaming-related RPCs like sending, consuming and managing consumer offsets. [rocketmq]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5521:
URL: https://github.com/apache/rocketmq/pull/5521#issuecomment-1817683646

   This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ISSUE #5516] Support sending a bound of sub-requests IN ONE RPC, especially for data-streaming-related RPCs like sending, consuming and managing consumer offsets. [rocketmq]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5521:
URL: https://github.com/apache/rocketmq/pull/5521#issuecomment-1823679143

   This PR was closed because it has been inactive for 3 days since being marked as stale.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org