You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/10/17 22:05:57 UTC
[GitHub] [cordova-android] raphinesse opened a new pull request #1095: fix(device.list): do not mess with following `adb devices` runs
raphinesse opened a new pull request #1095:
URL: https://github.com/apache/cordova-android/pull/1095
If the `lookHarder` option is true and the initial `adb devices` run
returned no devices, `device.list` will kill the adb server and try
again.
Unfortunately `adb devices` contains incorrect information when it is
run too soon after the adb server has been restarted. Consider below
commands being executed with one running emulator:
adb devices && killall adb && adb devices && adb devices
While the first invocation of `adb devices` lists the emulator as
running, the second and third one will list it as offline. This is
especially problematic if code contains a sequence such as:
devs = await device.list(true);
emus = await emulator.list();
In that case the third invocation of `adb devices` occurs in
`emulator.list()` but because of the `killall` it lists all emulators as
offline, causing `emus` to be empty.
This commit tries to work around that issue by explicitly restarting the
adb server after it was killed, and waiting for 100 ms after that. Local
experimentation has shown this to be sufficient in all instances. YMMV
of course.
Fixes the problem found by @breautek when reviewing #1082
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io commented on pull request #1095: fix(device.list): do not mess with following `adb devices` runs
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1095:
URL: https://github.com/apache/cordova-android/pull/1095#issuecomment-711086227
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1095?src=pr&el=h1) Report
> Merging [#1095](https://codecov.io/gh/apache/cordova-android/pull/1095?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/5d3591b8537647c0cc145308028e537c83e7ffd6?el=desc) will **decrease** coverage by `0.12%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/cordova-android/pull/1095?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1095 +/- ##
==========================================
- Coverage 69.83% 69.70% -0.13%
==========================================
Files 20 20
Lines 1810 1809 -1
==========================================
- Hits 1264 1261 -3
- Misses 546 548 +2
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1095?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/device.js](https://codecov.io/gh/apache/cordova-android/pull/1095/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9kZXZpY2UuanM=) | `100.00% <100.00%> (ø)` | |
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/1095/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `58.49% <0.00%> (-0.95%)` | :arrow_down: |
| [bin/templates/cordova/lib/retry.js](https://codecov.io/gh/apache/cordova-android/pull/1095/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9yZXRyeS5qcw==) | `100.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1095?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1095?src=pr&el=footer). Last update [5d3591b...144cc75](https://codecov.io/gh/apache/cordova-android/pull/1095?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on pull request #1095: fix(device.list): do not mess with following `adb devices` runs
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1095:
URL: https://github.com/apache/cordova-android/pull/1095#issuecomment-711086227
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on pull request #1095: fix(device.list): do not mess with following `adb devices` runs
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1095:
URL: https://github.com/apache/cordova-android/pull/1095#issuecomment-711086227
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1095?src=pr&el=h1) Report
> Merging [#1095](https://codecov.io/gh/apache/cordova-android/pull/1095?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/5d3591b8537647c0cc145308028e537c83e7ffd6?el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/cordova-android/pull/1095?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1095 +/- ##
==========================================
- Coverage 69.83% 69.81% -0.02%
==========================================
Files 20 20
Lines 1810 1809 -1
==========================================
- Hits 1264 1263 -1
Misses 546 546
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1095?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/device.js](https://codecov.io/gh/apache/cordova-android/pull/1095/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9kZXZpY2UuanM=) | `100.00% <100.00%> (ø)` | |
| [bin/templates/cordova/lib/retry.js](https://codecov.io/gh/apache/cordova-android/pull/1095/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9yZXRyeS5qcw==) | `100.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1095?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1095?src=pr&el=footer). Last update [5d3591b...144cc75](https://codecov.io/gh/apache/cordova-android/pull/1095?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] raphinesse edited a comment on pull request #1095: fix(device.list): do not mess with following `adb devices` runs
Posted by GitBox <gi...@apache.org>.
raphinesse edited a comment on pull request #1095:
URL: https://github.com/apache/cordova-android/pull/1095#issuecomment-711149684
I will probably fix this as part of a bigger refactoring. Converting to draft for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] raphinesse closed pull request #1095: fix(device.list): do not mess with following `adb devices` runs
Posted by GitBox <gi...@apache.org>.
raphinesse closed pull request #1095:
URL: https://github.com/apache/cordova-android/pull/1095
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] raphinesse commented on pull request #1095: fix(device.list): do not mess with following `adb devices` runs
Posted by GitBox <gi...@apache.org>.
raphinesse commented on pull request #1095:
URL: https://github.com/apache/cordova-android/pull/1095#issuecomment-711149684
I will probably fix this as part of a bigger refactoring
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] raphinesse commented on pull request #1095: fix(device.list): do not mess with following `adb devices` runs
Posted by GitBox <gi...@apache.org>.
raphinesse commented on pull request #1095:
URL: https://github.com/apache/cordova-android/pull/1095#issuecomment-712024697
Closing in favor of #1098
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org