You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by GitBox <gi...@apache.org> on 2021/10/25 17:16:12 UTC
[GitHub] [maven-wrapper-plugin] hboutemy opened a new pull request #1: [MWRAPPER-14] first step at putting all wrapper pieces in one build
hboutemy opened a new pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1
Wrapper consists in 3 pieces:
- wrapper (maven-wrapper.jar)
- wrapper distribution (mvnw scripts)
- wrapper plugin
that should have the same version = "the wrapper version"
the wrapper plugin will unpack wrapper distribution with the same version as the plugin
the only drawback vs releasing wrapper and wrapper distribution in the Apache Maven core release is that partial mvn scripts (3 shell and 3 cmd) are copied
but in terms of versions clarity, seems much easier to understand: wrapper is something, Maven is something
notice that this is a WIP: I did not yet review maven-wrapper-plugin logic to select the distribution version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-974609919
ok, so no objection to merge this PR?
please approve it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] jvanzyl commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
jvanzyl commented on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-970336499
Historically the Maven Wrapper has been separate, and I believe works well that way. Its concern to bring Maven into existence for build, and I would argue that should be any version of Maven. The simple fact that the Takari Maven Wrapper still needs to exist is an indication that we have an issue. I understand the maintenance issue with the scripts, but I think @slawekjaranowski has an elegant solution to that problem.
I would very much like to archive the Takari Maven Wrapper repository, and add some features to the wrapper at Apache. With the wrapper separated we may even be able to help people still using Maven 2.x (I've seen lots of 2.x projects) as the wrapper makes CI so much easier. But again, I think the wrapper has a separate concern, and we may want to add new features to the wrapper and it's been very nice with the Takari Maven Wrapper to just release it when necessary without concern for any particular version of Maven.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-974609919
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] jvanzyl commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
jvanzyl commented on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980635194
I'm not sure why the slight change was made, but the latest published instructions put the JAR in there by default. Just a warning that it's asking for potential support issues. Maybe someone has one network setup and commits the wrapper change not noticing the JAR isn't there. Changes network setups and their network or corporate setup doesn't allow access.
I think it's nicer not to have any JARs checked in but changing the way it works before it's released may not make for a great first release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] rfscholte commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-970356340
The only potential problem I see is that a script calls another script that calls java. Should be easy to validate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy edited a comment on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
hboutemy edited a comment on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-974664732
wrong logic: not merging MWRAPPER-14 (and not releasing a usable wrapper) does not help on evolving with MWRAPPER-16
please think again: scripts released as part of Maven core do not help to have consistency between wrapper scripts copied to project Git and scripts from downloaded Maven distribution = the right objective we share. It just helps on their maintenance in ASF Git (between maven.git and maven-wrapper-plugin.git), at the cost of a confusing release cycle and limitation on possible target Maven version (future Maven 4 only)
but at least, I can create MWRAPPER-16 branch to be merged to MWRAPPER-14: it's just sad to not be able to work in a constructive way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] slawekjaranowski edited a comment on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
slawekjaranowski edited a comment on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980598578
@hboutemy great job.
I've tested by:
- build project - unit and IT test are executed, plugin and artifacts are installed
- use in another project with some of released maven version ... looks ok
In this point of time I'm not looking deeper in code, simple build and use.
I think that push this code to public repo and release this version as is - will be the best approach.
It opens a way to testing by other users as well.
Next improvement can be done in small, easy to review changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] rfscholte commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-983747573
In the end the-person-that-called-wrapper:wrapper should decide. It is a matter of a "sources-only repository" (either download via script or Java) versus "don't download", not the "cloner/forker".
To me it is weird we make an exception for the wrapper.jar, whereas we all prefer sources only for everything else.
IIUC everything is configurable to download, including repo-manager, proxy, etc. It should be possible to guide in case it doesn't work.
Also, regarding the potential unintended commit: the plugin could help here generating scm-specific ignore files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy edited a comment on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
hboutemy edited a comment on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-974664732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-974664732
wrong logic: not merging MWRAPPER-14 (and not releasing a usable wrapper) does not help on evolving with MWRAPPER-16
please think again: scripts released as part of Maven core do not work as a way to have consistency between wrapper scripts copied to project Git and scripts from downloaded maven distribution. It just helps a little bit their maintenance, at the cost of a confusion release cycle and limitation on possible target Maven version (future Maven 4 only)
but at least, I can create MWRAPPER-16 branch to be merged to MWRAPPER-14: it's just sad to not be able to work in a constructive way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] rfscholte commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-983365226
The choice for `script` was because in general we don't want binaries in the SCM. There's no real damage if the file is committed anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] slawekjaranowski commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-952590460
I think that running `mvn` from Maven distribution will be better ...
Some change to maven scripts can be depend on Maven core code like:
https://github.com/apache/maven/pull/602
so what will happen when we have newer scripts in wrapper and want to setup older Maven to use ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy edited a comment on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
hboutemy edited a comment on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-951301704
I completely value the work done to sync mvn and mvnw: syncing again is just about copying the 6 partial scripts to `maven-wrapper-distribution/src/assembly/maven/`.
on releasing, there is only 1 simultaneous release for the 3 artifacts: wrapper, wrapper distribution and wrapper-plugin = the full wrapper, clearly separate from the Maven distribution. It is really simple and logical.
And there won't be many releases in the future, because everything is independant from Maven version.
with the latest commits, the new wrapper is working well with whatever Maven version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980543639
last try:
- code = https://github.com/hboutemy/maven-wrapper = the initial wrapper donation with 4 commits to switch to Apache, replace provisio to assembly, add maven-wrapper-plugin and document
- site: https://maven.apache.org/wrapper-archives/wrapper-LATEST/
This approach of wrapper does not need any releases when new Maven versions are released, and can work with any version from the past (like the original donation), and any SNAPSHOT
Getting identical features of installed mvnw in a project Git vs downloaded Maven distribution will be part of MWRAPPER-16 = stop trying to re-implement mvn logic to launch a JVM and Maven core, but call mvn = the only solution to get consistency
all, please review: in the end, I expect to create a maven-wrapper.git repository containing my initial work (that contains initial donation), and we'll track future features an release normally in MWRAPPER Jira
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy edited a comment on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
hboutemy edited a comment on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-951301704
I completely value the work done to sync mvn and mvnw: syncing is just about copying the 6 partial scripts.
on releasing, there is only 1 simultaneous release for the 3 artifacts: wrapper, wrapper distribution and wrapper-plugin = the full wrapper, clearly separate from the Maven distribution. It is really simple and logical.
And there won't be many releases in the future, because everything is independant from Maven version.
with the latest commits, the new wrapper is working well with whatever Maven version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] rfscholte commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-951816397
@slawekjaranowski if that would work, that would be a much more acceptable solution for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] rfscholte commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-951615646
So how do you intend to keep up with changes like https://github.com/apache/maven/pull/602 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-952568787
yes, instead of copying by hand partial scripts from https://github.com/apache/maven/tree/master/apache-maven/src/assembly/shared to current project source https://github.com/apache/maven-wrapper-plugin/tree/MWRAPPER-14/maven-wrapper-distribution/src/assembly/maven , it can be automated => I'll add this soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy edited a comment on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
hboutemy edited a comment on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-974664732
wrong logic: not merging MWRAPPER-14 (and not releasing a usable wrapper) does not help on evolving with MWRAPPER-16
please think again: scripts released as part of Maven core do not help to have consistency between wrapper scripts copied to project Git and scripts from downloaded maven distribution = the right objective we share. It just helps on their maintenance in ASF Git, at the cost of a confusion release cycle and limitation on possible target Maven version (future Maven 4 only)
but at least, I can create MWRAPPER-16 branch to be merged to MWRAPPER-14: it's just sad to not be able to work in a constructive way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] jvanzyl commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
jvanzyl commented on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980633136
I think that's a poor default behavior, and the `type=bin` should be the default. That's not how the current released wrapper work, no one will read the docs and the first experience from new users will be poor, and not what's expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] slawekjaranowski commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980633392
Of course, `wrapperUrl` in properties is wrong, but release (even staging) should resolve it
```
wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.0.3-SNAPSHOT/maven-wrapper-3.0.3-SNAPSHOT.zip
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-983699652
ok, code pushed in MWRPPER-14 branch in maven-studies https://github.com/apache/maven-studies/tree/MWRAPPER-14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] slawekjaranowski commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980632912
in `maven-wrapper`
```
mvn clean install -P run-its
```
and in other project
```
mvn org.apache.maven.plugins:maven-wrapper-plugin:3.0.3-SNAPSHOT:wrapper -Dtype=bin -Dmaven=3.6.2
```
important is `type=bin`, so I have:
```
tree .mvn/
.mvn/
└── wrapper
├── maven-wrapper.jar
└── maven-wrapper.properties
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy edited a comment on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
hboutemy edited a comment on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980641749
but for sure, there is the question: what should be the default? current `script`or `bin` as it was in Takari?
I kept the `script` default value that Robert chose previously, changing is easy, it's really just a choice to do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980641749
but for sure, there is the question: what should be the default? current `script`or `bin`?
I kept the `script` default value that Robert chose previously, changing is easy, it's really just a choice to do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] rfscholte commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-974648100
it still contains the copy of the original scripts, right? Then I'm -1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] rfscholte commented on a change in pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#discussion_r753767354
##########
File path: maven-wrapper-distribution/src/assembly/script/download
##########
@@ -0,0 +1,51 @@
+##########################################################################################
+# Extension to allow automatically downloading the maven-wrapper.jar from Maven-central
+# This allows using the maven wrapper in projects that prohibit checking in binary data.
+##########################################################################################
+if [ -r "$MAVEN_PROJECTBASEDIR/.mvn/wrapper/maven-wrapper.jar" ]; then
+ if [ "$MVNW_VERBOSE" = true ]; then
+ echo "Found .mvn/wrapper/maven-wrapper.jar"
+ fi
+else
+ if [ "$MVNW_VERBOSE" = true ]; then
+ echo "Couldn't find .mvn/wrapper/maven-wrapper.jar, downloading it ..."
+ fi
+
+ jarUrl="https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/${project.version}/maven-wrapper-${project.version}.jar"
Review comment:
I don't think this ( ${project.version} ) is going to work. At Maven-Core it would pick up the version of the distribution. It should not pick up the version of the plugin and we shouldn't release the plugin with every new release of Maven, which would bring us back to square one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] rfscholte commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-974648100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] rfscholte commented on a change in pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#discussion_r753829576
##########
File path: maven-wrapper/src/main/java/org/apache/maven/wrapper/MavenWrapperMain.java
##########
@@ -0,0 +1,110 @@
+package org.apache.maven.wrapper;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.net.URI;
+import java.net.URISyntaxException;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.Properties;
+
+/**
+ * Main entry point for the Maven Wrapper, delegating wrapper execution to {@link WrapperExecutor}.
+ *
+ * @author Hans Dockter
+ */
+public class MavenWrapperMain
+{
+ private static final String POM_PROPERTIES =
+ "/META-INF/maven/org.apache.maven.wrapper/maven-wrapper/pom.properties";
+
+ public static final String DEFAULT_MAVEN_USER_HOME = System.getProperty( "user.home" ) + "/.m2";
+
+ public static final String MVNW_VERBOSE = "MVNW_VERBOSE";
+
+ public static final String MVNW_USERNAME = "MVNW_USERNAME";
+
+ public static final String MVNW_PASSWORD = "MVNW_PASSWORD";
+
+ public static final String MVNW_REPOURL = "MVNW_REPOURL";
+
+ public static final String MVN_VERSION = "3.8.3";
Review comment:
If this value needs to be in sync with the Maven release, then this class (and its artifact) doesn't belong here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] jvanzyl commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
jvanzyl commented on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-974671779
@rfscholte are you fine with a first step of dynamically importing the scripts and implementing the more sophisticated https://issues.apache.org/jira/browse/MWRAPPER-16 later? I’d really like to shut down the Takari Wrapper repo sooner rather than later, if possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] rfscholte commented on a change in pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#discussion_r753767354
##########
File path: maven-wrapper-distribution/src/assembly/script/download
##########
@@ -0,0 +1,51 @@
+##########################################################################################
+# Extension to allow automatically downloading the maven-wrapper.jar from Maven-central
+# This allows using the maven wrapper in projects that prohibit checking in binary data.
+##########################################################################################
+if [ -r "$MAVEN_PROJECTBASEDIR/.mvn/wrapper/maven-wrapper.jar" ]; then
+ if [ "$MVNW_VERBOSE" = true ]; then
+ echo "Found .mvn/wrapper/maven-wrapper.jar"
+ fi
+else
+ if [ "$MVNW_VERBOSE" = true ]; then
+ echo "Couldn't find .mvn/wrapper/maven-wrapper.jar, downloading it ..."
+ fi
+
+ jarUrl="https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/${project.version}/maven-wrapper-${project.version}.jar"
Review comment:
I don't think this ( ${project.version} ) is going to work. At Maven-Core it would pick up the version of the distribution. It should not pick up the version of the plugin and we shouldn't release the plugin with every new release of Maven, which would bring us back to square one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy edited a comment on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
hboutemy edited a comment on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980639933
the issue you have is only with SNAPSHOTs of maven-wrapper, that are obviously not published to central
But with releases, there won't be any problem for normal users using default
during development with SNAPSHOT maven-wrapper, see last section of https://maven.apache.org/wrapper-archives/wrapper-LATEST/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980639933
the issue you have is only with SNAPSHOTs or maven-wrapper, that are obvioulsy not published to central
But with releases, there won't be any problem for normal users using default
during development with SNAPSHOT maven-wrapper, see last section of https://maven.apache.org/wrapper-archives/wrapper-LATEST/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy edited a comment on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
hboutemy edited a comment on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980543639
last try:
- code = https://github.com/hboutemy/maven-wrapper = the initial wrapper donation with 4 commits to switch to Apache, replace provisio to assembly, add maven-wrapper-plugin and document
- site: https://maven.apache.org/wrapper-archives/wrapper-LATEST/
This approach of wrapper does not need any releases when new Maven versions are released, and can work with any version from the past and any Maven SNAPSHOT (like the original donation)
Getting identical features of installed `mvnw` in a project Git vs downloaded Maven distribution `mvn` will be part of MWRAPPER-16 = stop trying to re-implement `mvn` logic in `mvnw` to launch a JVM and Maven core, but call mvn = the only solution to get consistency
all, please review: in the end, I expect to create a maven-wrapper.git repository containing my initial work (that contains initial donation), and we'll track future features an release normally in MWRAPPER Jira
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] slawekjaranowski commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980598578
@hboutemy great job.
I've tested by:
- build project - unit and IT test are executed, plugin and artifacts are installed
- use in another project with some of released maven version ... looks ok
In this point of time I'm not looking deeper in code, simple build and use.
I think that push this code to public repo and release this version as is - will be the best approach.
It opens a way. to testing by other users as well.
Next improvement can be done in small, easy to review changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-952594433
oh, yes, sorry, please forget my previous comment: morning coffe took more time than I expected to warm up my brain :)
Yes, having `mvnw` script (stored in source control) call downloaded `mvn` from the Maven distribution is the only solution to be sure that exact features are available
to implement it, we'll need to have `mvnw`script know where the Maven distribution has been unpacked (by `maven-wrapper.jar`): any idea how to do that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] rfscholte commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-983367640
There are still things in the code I want to comment on, but that's hard to describe here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy edited a comment on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
hboutemy edited a comment on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-974664732
wrong logic: not merging MWRAPPER-14 (and not releasing a usable wrapper) does not help on evolving with MWRAPPER-16
please think again: scripts released as part of Maven core do not help to have consistency between wrapper scripts copied to project Git and scripts from downloaded maven distribution = the right objective we share. It just helps on their maintenance in ASF Git (between maven.git and maven-wrapper-plugin.git), at the cost of a confusion release cycle and limitation on possible target Maven version (future Maven 4 only)
but at least, I can create MWRAPPER-16 branch to be merged to MWRAPPER-14: it's just sad to not be able to work in a constructive way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy commented on a change in pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
hboutemy commented on a change in pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#discussion_r753846928
##########
File path: maven-wrapper/src/main/java/org/apache/maven/wrapper/MavenWrapperMain.java
##########
@@ -0,0 +1,110 @@
+package org.apache.maven.wrapper;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.net.URI;
+import java.net.URISyntaxException;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.Properties;
+
+/**
+ * Main entry point for the Maven Wrapper, delegating wrapper execution to {@link WrapperExecutor}.
+ *
+ * @author Hans Dockter
+ */
+public class MavenWrapperMain
+{
+ private static final String POM_PROPERTIES =
+ "/META-INF/maven/org.apache.maven.wrapper/maven-wrapper/pom.properties";
+
+ public static final String DEFAULT_MAVEN_USER_HOME = System.getProperty( "user.home" ) + "/.m2";
+
+ public static final String MVNW_VERBOSE = "MVNW_VERBOSE";
+
+ public static final String MVNW_USERNAME = "MVNW_USERNAME";
+
+ public static final String MVNW_PASSWORD = "MVNW_PASSWORD";
+
+ public static final String MVNW_REPOURL = "MVNW_REPOURL";
+
+ public static final String MVN_VERSION = "3.8.3";
Review comment:
yes, the more I'm merging back everything in one build, the more I'm in fact reverting many changes that were done while you tried to put some pieces in Maven core
you're probably right, instead of continuing the current branch, we probably better start again from original maven-wrapper history and merge maven-wrapper-plugin in it: that may be easier to get to a new stable situation
is it what you had in mind?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] rfscholte commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-983664558
Can https://github.com/hboutemy/maven-wrapper be cloned to maven-studies? That makes it easier for everybody to do their changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] rfscholte commented on pull request #1: [MWRAPPER-14] first step at putting all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-951204672
I'm not convinced this is the right thing to do. If you compare the original mvn and mvnw script when it was donated, you should have noticed that they both went their own way. It took me quite some time to get them in sync and to pick the best of both. By splitting it up it will happen again.
Maybe you should wait with this AFTER MNG-7073 so Maven contains a script template that can be reused here.
Moving the wrapper to here, does that mean that this plugin must be released every time is released too, like the takari plugin used to do? Then we've lost the benefit of the current setup, because most likely the plugin now doesn't require new releases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-962566868
I created https://issues.apache.org/jira/browse/MWRAPPER-16 to track this very good idea on `mvnw` launching `mvn` scripts: I hope we'll find a solution some day
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] jvanzyl edited a comment on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
jvanzyl edited a comment on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-970322319
> Another idea ... why not simply call `mvn*` scripts from Maven distribution ... of course after needed job for wrapper like downloading
>
> In this case code will be in one place
That's a great idea. I originally thought of a tiny plugin (I think one might actually exist) to have the core grab the scripts from the wrapper for reuse, but your idea is far better and essentially zero maintenance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] jvanzyl commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
jvanzyl commented on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-970322319
> Another idea ... why not simply call `mvn*` scripts from Maven distribution ... of course after needed job for wrapper like downloading
>
> In this case code will be in one place
That's a great idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] slawekjaranowski commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-970426760
From wrapper perspective should not be important what `mvn` command is and what happen inside `mvn`.
We should assume that `mvn` command from Maven distribution simply work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] jvanzyl edited a comment on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
jvanzyl edited a comment on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-970336499
Historically the Maven Wrapper has been separate, and I believe works well that way. Its concern to bring Maven into existence for build, and I would argue that should be any version of Maven. The simple fact that the Takari Maven Wrapper still needs to exist is an indication that we have an issue. I understand the maintenance issue with the scripts, but I think @slawekjaranowski has an elegant solution to that problem.
I would very much like to archive the Takari Maven Wrapper repository, and add some features to the wrapper at Apache. With the wrapper separated we may even be able to help people still using Maven 2.x (I've seen lots of 2.x projects) as the wrapper makes CI so much easier. But again, I think the wrapper has a separate concern, and we may want to add new features to the wrapper and it's been very nice with the Takari Maven Wrapper to just release it when necessary without concern for any particular version of Maven.
But I do think having the wrapper and wrapper plugin together makes sense. I didn't think about it very hard with the Takari Wrapper but it definitely would have been easier if all the wrapper capability was together. I think what's in the PR here with the addendum of @slawekjaranowski's solution is ideal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] rfscholte commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-974682770
This commit touches 75 files, and after MWRAPPER-16 a lot of them are removed.
Keep in mind that I moved it to maven-core due to the huge overlap of scripts, but that argument disappears with MWRAPPER-16.
I'd suggest to start from scratch with the scripts in MWRAPPER-14, and just skip MWRAPPER-14.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] rfscholte commented on a change in pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#discussion_r754017815
##########
File path: maven-wrapper/src/main/java/org/apache/maven/wrapper/MavenWrapperMain.java
##########
@@ -0,0 +1,110 @@
+package org.apache.maven.wrapper;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.net.URI;
+import java.net.URISyntaxException;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.Properties;
+
+/**
+ * Main entry point for the Maven Wrapper, delegating wrapper execution to {@link WrapperExecutor}.
+ *
+ * @author Hans Dockter
+ */
+public class MavenWrapperMain
+{
+ private static final String POM_PROPERTIES =
+ "/META-INF/maven/org.apache.maven.wrapper/maven-wrapper/pom.properties";
+
+ public static final String DEFAULT_MAVEN_USER_HOME = System.getProperty( "user.home" ) + "/.m2";
+
+ public static final String MVNW_VERBOSE = "MVNW_VERBOSE";
+
+ public static final String MVNW_USERNAME = "MVNW_USERNAME";
+
+ public static final String MVNW_PASSWORD = "MVNW_PASSWORD";
+
+ public static final String MVNW_REPOURL = "MVNW_REPOURL";
+
+ public static final String MVN_VERSION = "3.8.3";
Review comment:
Right, so there are a couple of things that have been solved by moving it from takari to maven-core:
- no additional releases required.
- identical scripts are in sync.
We shouldn't loose these improvements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] jvanzyl commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
jvanzyl commented on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-974671779
@rfscholte are you fine with a first step of dynamically importing the scripts and implementing the more sophisticated https://issues.apache.org/jira/browse/MWRAPPER-16 later? I’d really like to shut down the Takari Wrapper repo sooner rather than later, if possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] jvanzyl edited a comment on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
jvanzyl edited a comment on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980633136
@hboutemy I think that's poor default behavior, the `type=bin` should be the default. That's not how the current released wrapper works. No one will read the docs that's not what will be expected and the first experience from new users will be poor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] jvanzyl edited a comment on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
jvanzyl edited a comment on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980633136
@hboutemy I think that's poor default behavior, the `type=bin` should be the default. That's not how the current released wrapper works. No one will read the docs, that's not what will be expected and the first experience from new users will be poor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] jvanzyl edited a comment on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
jvanzyl edited a comment on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980613922
I run the following in the cloned repository itself:
```
mvn clean install
mvn org.apache.maven.plugins:maven-wrapper-plugin:3.0.3-SNAPSHOT:wrapper
./mvnw clean install
```
Which yields:
```
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
curl: (22) The requested URL returned error: 404
Error: Could not find or load main class org.apache.maven.wrapper.MavenWrapperMain
```
All I have in the `.mvn` directory is the following:
```
bash-3.2$ tree .mvn
.mvn
└── wrapper
└── maven-wrapper.properties
```
@slawekjaranowski how did you test it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-983710755
> The choice for `script` was because in general we don't want binaries in the SCM. There's no real damage if the file is committed anyway.
making script the default is not sufficient, because if .mvn/wrapper/maven-wrapper.jar or *.jar is not in .gitignore, the jar will inevitably come into future Git commit, not by the guy who did `mvn wrapper:wrapper`, by the user who will do `./mvnw` and commit everything without remarking that `wrapper.jar` was downloaded
then forcing `mvn wrapper:wrapper` not to download `maven-wrapper.jar` just adds an additional friction (= `mvnw` needs to be able to download the jar, without the help of Maven settings)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-951301704
I completely value the work done to sync mvn and mvnw: syncing is just about copying the 6 partial scripts.
on releasing, there is only 1 simultaneous release for the 3 artifacts: wrapper, wrapper distribution and wrapper-plugin = the full wrapper, clearly separate from the Maven distribution. It is really simple and logical.
with the latest commits, the new wrapper is working well with whatever Maven version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] slawekjaranowski commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-951775639
Another idea ... why not simply call `mvn*` scripts from Maven distribution ... of course after needed job for wrapper like downloading
In this case code will be in one place
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] rfscholte commented on a change in pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#discussion_r753767354
##########
File path: maven-wrapper-distribution/src/assembly/script/download
##########
@@ -0,0 +1,51 @@
+##########################################################################################
+# Extension to allow automatically downloading the maven-wrapper.jar from Maven-central
+# This allows using the maven wrapper in projects that prohibit checking in binary data.
+##########################################################################################
+if [ -r "$MAVEN_PROJECTBASEDIR/.mvn/wrapper/maven-wrapper.jar" ]; then
+ if [ "$MVNW_VERBOSE" = true ]; then
+ echo "Found .mvn/wrapper/maven-wrapper.jar"
+ fi
+else
+ if [ "$MVNW_VERBOSE" = true ]; then
+ echo "Couldn't find .mvn/wrapper/maven-wrapper.jar, downloading it ..."
+ fi
+
+ jarUrl="https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/${project.version}/maven-wrapper-${project.version}.jar"
Review comment:
I don't think this ( ${project.version} ) is going to work. At Maven-Core it would pick up the version of the distribution. It should not pick up the version of the plugin and we shouldn't release the plugin with every new release of Maven, which would bring us back to square one.
##########
File path: maven-wrapper-distribution/src/assembly/script/download
##########
@@ -0,0 +1,51 @@
+##########################################################################################
+# Extension to allow automatically downloading the maven-wrapper.jar from Maven-central
+# This allows using the maven wrapper in projects that prohibit checking in binary data.
+##########################################################################################
+if [ -r "$MAVEN_PROJECTBASEDIR/.mvn/wrapper/maven-wrapper.jar" ]; then
+ if [ "$MVNW_VERBOSE" = true ]; then
+ echo "Found .mvn/wrapper/maven-wrapper.jar"
+ fi
+else
+ if [ "$MVNW_VERBOSE" = true ]; then
+ echo "Couldn't find .mvn/wrapper/maven-wrapper.jar, downloading it ..."
+ fi
+
+ jarUrl="https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/${project.version}/maven-wrapper-${project.version}.jar"
Review comment:
I don't think this ( ${project.version} ) is going to work. At Maven-Core it would pick up the version of the distribution. It should not pick up the version of the plugin and we shouldn't release the plugin with every new release of Maven, which would bring us back to square one.
##########
File path: maven-wrapper/src/main/java/org/apache/maven/wrapper/MavenWrapperMain.java
##########
@@ -0,0 +1,110 @@
+package org.apache.maven.wrapper;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.net.URI;
+import java.net.URISyntaxException;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.Properties;
+
+/**
+ * Main entry point for the Maven Wrapper, delegating wrapper execution to {@link WrapperExecutor}.
+ *
+ * @author Hans Dockter
+ */
+public class MavenWrapperMain
+{
+ private static final String POM_PROPERTIES =
+ "/META-INF/maven/org.apache.maven.wrapper/maven-wrapper/pom.properties";
+
+ public static final String DEFAULT_MAVEN_USER_HOME = System.getProperty( "user.home" ) + "/.m2";
+
+ public static final String MVNW_VERBOSE = "MVNW_VERBOSE";
+
+ public static final String MVNW_USERNAME = "MVNW_USERNAME";
+
+ public static final String MVNW_PASSWORD = "MVNW_PASSWORD";
+
+ public static final String MVNW_REPOURL = "MVNW_REPOURL";
+
+ public static final String MVN_VERSION = "3.8.3";
Review comment:
If this value needs to be in sync with the Maven release, then this class (and its artifact) doesn't belong here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] jvanzyl commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
jvanzyl commented on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980613922
I run the following in the clone repository itself:
```
mvn clean install
mvn org.apache.maven.plugins:maven-wrapper-plugin:3.0.3-SNAPSHOT:wrapper
./mvnw clean install
```
Which yields:
```
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
curl: (22) The requested URL returned error: 404
Error: Could not find or load main class org.apache.maven.wrapper.MavenWrapperMain
```
All I have in the `.mvn` directory is the following:
```
bash-3.2$ tree .mvn
.mvn
└── wrapper
└── maven-wrapper.properties
```
@slawekjaranowski how did you test it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980644191
thinking at default type more in depth, I think that I now understand the logic
= making `script` the default is not sufficient, because if `.mvn/wrapper/maven-wrapper.jar` or `*.jar` is not in `.gitignore`, the jar will inevitably come into future Git commit
then the logic is to have `bin` by default when installing maven-wrapper, and the `.gitignore` configuration will trigger if the jar is stored or not (and if not stored, the consequence in network access)
thinking like this, I now feel that yes, `bin` should be default...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org