[GitHub] [arrow-rs] jackwener commented on issue #4325: Question: Could we move `dict_id, dict_is_ordered` into DataType?

["jackwener (via GitHub)" <gi...@apache.org>]

jackwener commented on issue #4325:
URL: https://github.com/apache/arrow-rs/issues/4325#issuecomment-1571233029

   > What would be the advantage of such a change? 
   
   `dict_id: i64, dict_is_ordered: bool` is useless when `DataType` isn't `Dictionary`, so look like they shouldn't be put in `Field`. And it will waste a little memory.
   
   > I'm mainly just thinking that this will result in a huge amount of code churn, and so would need quite a strong justification
   
   I agree with it, I also think we don't have a particularly strong motivation to change it.
   
   I also have a question. If we change it, does this create incompatible behavior?
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org