[GitHub] [kafka] dajac commented on a diff in pull request #12187: KAFKA-13858; Kraft should not shutdown metadata listener until controller shutdown is finished

[GitBox <gi...@apache.org>]

dajac commented on code in PR #12187:
URL: https://github.com/apache/kafka/pull/12187#discussion_r879162306


##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -2134,10 +2141,13 @@ class ReplicaManager(val config: KafkaConfig,
             stateChangeLogger.trace(s"Unable to start fetching $tp with topic " +
               s"ID ${info.topicId} because the replica manager is shutting down.")
           } else {
-            val leader = info.partition.leader
-            if (newImage.cluster.broker(leader) == null) {
+            if (isInControlledShutdown && !info.partition.isr.contains(config.brokerId)) {

Review Comment:
   That makes sense. I forgot about this case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org