You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hugegraph.apache.org by "imbajin (via GitHub)" <gi...@apache.org> on 2026/10/14 01:40:44 UTC
[PR] fix: preserve int map entries during resize [hugegraph]
imbajin opened a new pull request, #3341:
URL: https://github.com/apache/hugegraph/pull/3341
Concurrent map growth could hash a key using one table generation and access another, losing entries. A competing chain update could also make removal report an existing key as absent.
Hashing now uses the captured table's length, and removal retries a failed compare-and-set while the key is still present. Parallel regressions check reads, removals, retained values and final size while maps grow.
Validation: the original implementation and the first partial fix fail the native regressions; the final candidate passes the IntMap suite, Java 17 clean compilation and EditorConfig formatting. Three independent reviews passed.
Doc - No Need: this corrects internal collection behavior without changing configuration, APIs or persisted formats.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix: preserve int map entries during resize [hugegraph]
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin merged PR #3341:
URL: https://github.com/apache/hugegraph/pull/3341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix: preserve int map entries during resize [hugegraph]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3341:
URL: https://github.com/apache/hugegraph/pull/3341#issuecomment-6159212041
## [Codecov](https://app.codecov.io/gh/apache/hugegraph/pull/3341?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 42.24%. Comparing base ([`92af2f8`](https://app.codecov.io/gh/apache/hugegraph/commit/92af2f89c320c3e6fa7c10765a061f3edadea319?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fe041d0`](https://app.codecov.io/gh/apache/hugegraph/commit/fe041d0c955d1713375473d1191d48b65f79c6b8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hugegraph/pull/3341?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...hugegraph/util/collection/IntMapByDynamicHash.java](https://app.codecov.io/gh/apache/hugegraph/pull/3341?src=pr&el=tree&filepath=hugegraph-server%2Fhugegraph-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhugegraph%2Futil%2Fcollection%2FIntMapByDynamicHash.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVnZWdyYXBoLXNlcnZlci9odWdlZ3JhcGgtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVnZWdyYXBoL3V0aWwvY29sbGVjdGlvbi9JbnRNYXBCeUR5bmFtaWNIYXNoLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hugegraph/pull/3341?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (92af2f8) and HEAD (fe041d0). Click for more details.
>
> <details><summary>HEAD has 6 uploads less than BASE</summary>
>
>| Flag | BASE (92af2f8) | HEAD (fe041d0) |
>|------|------|------|
>||7|1|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3341 +/- ##
=============================================
- Coverage 54.31% 42.24% -12.07%
+ Complexity 2250 2 -2248
=============================================
Files 770 503 -267
Lines 67952 48399 -19553
Branches 9213 6963 -2250
=============================================
- Hits 36905 20446 -16459
+ Misses 27470 25581 -1889
+ Partials 3577 2372 -1205
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/hugegraph/pull/3341?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org