You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@isis.apache.org by "Daniel Keir Haywood (Jira)" <ji...@apache.org> on 2020/01/07 17:32:00 UTC

[jira] [Resolved] (ISIS-2255) In WrapperFactory, lookup mixin properties and collections (as well as actions).

     [ https://issues.apache.org/jira/browse/ISIS-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Keir Haywood resolved ISIS-2255.
---------------------------------------
    Resolution: Fixed

> In WrapperFactory, lookup mixin properties and collections (as well as actions).
> --------------------------------------------------------------------------------
>
>                 Key: ISIS-2255
>                 URL: https://issues.apache.org/jira/browse/ISIS-2255
>             Project: Isis
>          Issue Type: Improvement
>            Reporter: Daniel Keir Haywood
>            Assignee: Daniel Keir Haywood
>            Priority: Minor
>             Fix For: 2.0.0
>
>
> Because we are now more strict about the bookmarks that can be created (in particular, because we do not allow bookmarks to be created on transient objects such as mixins), then the previous code was failing when attempting to create an InteractionDto with a bookmark to a mixin.
> Tracking this down, this was because of the invocation of a contributed collection via the WrapperFactory.  The WrapperFactory (more precisely, DomainObjectInvocationHandler) attempts to do a "reverse-looking" to find the contributed mixed member  from the original action on the mixin, but only searched for contributed actions, and did not consider contributed properties or collections.
> This change is to fix this.  It should mean that the targetAdapter for InteractionDto's is always correct, and that memberIdentifier == logicalMemberIdentifier in all cases.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)