[GitHub] [airflow] thinhnd2104 commented on pull request #23881: Generic S3 to SQL

[GitBox <gi...@apache.org>]

thinhnd2104 commented on PR #23881:
URL: https://github.com/apache/airflow/pull/23881#issuecomment-1143838001

   > General questions and reminders:
   > 
   >     * Did you test you operator in a DAG?
   > 
   >     * Please add unit tests for the operator
   > 
   >     * Please add a sample dag here `airflow/providers/amazon/aws/example_dags/example_s3_to_sql.py`. You can take a look at an example, `airflow/providers/amazon/aws/example_dags/example_sql_to_s3.py` should be pretty similar
   > 
   >     * Please add documentation here `docs/apache-airflow-providers-amazon/operators/transfer/s3_to_sql.rst`. Same as the example dag, feel free to look at other documentation and try to follow the same format
   > 
   > 
   > Thank you for adding this operator :)
   
   Thanks for your comments. In my case, I execute this operator on ECS cluster by docker image =)) so I will test this operator and add unit test later. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org