You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by Justin Mason <jm...@jmason.org> on 2004/02/11 21:45:16 UTC
Re: I'm missing code and SVN drives me nuts
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Malte S. Stretz writes:
>Hi folks,
>
>I'm currently trying to apply my patch from bug 2536 and it seems like some
>code which was fixed by that one is gone. I'm talking about hunk #1 and #4.
>Just look for those (messy) routines get_user_from_address() and
>fill_qmailu_cache().
>
>What happened to them? Were they probably dropped because a CLA wasn't
>submitted?
Yes. They're in the "asfpurgatory" module, in vpopmail.diff, but
we have no CLA for that code, so it's gone :(
I have no idea how to use svn to find the diff btw ;) I'd suggest
trying the viewcvs site.
- --j.
> I tried to find that out and SVN just didn't DWIM. To see what I
>mean try an 'svn log spamd.raw' and have a look at that change in r6006
>(and 5993). Can anybody tell me how I get a diff for those? I tried every
>possible combinations of revisions and SVN continues to tell me "bleh,
>there was no change"... What I tried was:
> svn diff -r 6006:6005 spamd.raw
> svn diff -r 6007:6005 spamd.raw
> svn diff -r 6006:5993 spamd.raw
> svn diff -r 6006:6007 spamd.raw
> svn diff -r 6000:6007 spamd.raw
> svn diff -r 5993:5992 spamd.raw
> svn diff -r 5994:5993 spamd.raw
> svn diff -r 5994:5992 spamd.raw
> svn diff -r 5994:5972 spamd.raw
> svn diff -r 5994:5971 spamd.raw
>
>I'm feeling stupid...
>
>Malte
>
>--
>[SGT] Simon G. Tatham: "How to Report Bugs Effectively"
> <http://www.chiark.greenend.org.uk/~sgtatham/bugs.html>
>[ESR] Eric S. Raymond: "How To Ask Questions The Smart Way"
> <http://www.catb.org/~esr/faqs/smart-questions.html>
>
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
Comment: Exmh CVS
iD8DBQFAKpRcQTcbUG5Y7woRAscGAJwJA9RwB6o493yISBy6UqxttrzUPwCeOKs+
9/MBr7gZAZQV/cUXA5Ie+Sw=
=lyQN
-----END PGP SIGNATURE-----
Re: I'm missing code and SVN drives me nuts
Posted by "Malte S. Stretz" <ms...@gmx.net>.
On Wednesday 11 February 2004 21:45 CET Justin Mason wrote:
> Malte S. Stretz writes:
> >I'm currently trying to apply my patch from bug 2536 and it seems like
> > some code which was fixed by that one is gone. I'm talking about hunk
> > #1 and #4. Just look for those (messy) routines get_user_from_address()
> > and fill_qmailu_cache().
> >
> >What happened to them? Were they probably dropped because a CLA wasn't
> >submitted?
>
> Yes. They're in the "asfpurgatory" module, in vpopmail.diff, but
> we have no CLA for that code, so it's gone :(
Hm, my code is a complete rewrite of that stuff, but it was definitely not a
clean-room one.
If anybody told me what it did I could reimplement it again; when I
refactored it, all I did was keeping the functionality it provided but
didn't really know what the called commands return :)
Is this functionality needed/wanted? (I think so because I heard at least
five complaints about the qmail code within the last four months.)
I'll adapt the fixes which still apply this weekend, for the rest we've
gotta see...
Cheers,
Malte
--
[SGT] Simon G. Tatham: "How to Report Bugs Effectively"
<http://www.chiark.greenend.org.uk/~sgtatham/bugs.html>
[ESR] Eric S. Raymond: "How To Ask Questions The Smart Way"
<http://www.catb.org/~esr/faqs/smart-questions.html>