You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/20 16:33:42 UTC

[GitHub] [airflow] bbovenzi commented on a diff in pull request #28411: Fix calendar view for CronTriggerTimeTable dags

bbovenzi commented on code in PR #28411:
URL: https://github.com/apache/airflow/pull/28411#discussion_r1053517558


##########
airflow/www/views.py:
##########
@@ -2828,7 +2828,7 @@ def _convert_to_date(session, column):
             restriction = TimeRestriction(dag.start_date, dag.end_date, False)
             dates = collections.Counter()
 
-            if isinstance(dag.timetable, CronDataIntervalTimetable):
+            if isinstance(dag.timetable, CronTriggerTimetable):

Review Comment:
   1. Included both cron timetables in the if statement
   
   2. `next_dagrun_info` was always the same [here](https://github.com/apache/airflow/blob/main/airflow/www/views.py#L2844). So we never reached either of the `break` statements. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org