You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/02/10 01:41:28 UTC
[GitHub] [hudi] vinothchandar commented on a change in pull request #2540: [HUDI-1586] [Common Core] [Flink Integration] Reduce the coupling of hadoop.
vinothchandar commented on a change in pull request #2540:
URL: https://github.com/apache/hudi/pull/2540#discussion_r573380111
##########
File path: hudi-common/pom.xml
##########
@@ -154,6 +155,7 @@
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-hdfs</artifactId>
+ <scope>provided</scope>
Review comment:
wondering if the parent pom scope is already `provided` , is nt that inherited>?
##########
File path: hudi-flink/pom.xml
##########
@@ -157,7 +157,7 @@
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-common</artifactId>
- <scope>compile</scope>
+ <scope>provided</scope>
Review comment:
same questions on the need to repeat this again in the child modules
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/fs/FSUtils.java
##########
@@ -80,9 +80,6 @@
private static final PathFilter ALLOW_ALL_FILTER = file -> true;
public static Configuration prepareHadoopConf(Configuration conf) {
- conf.set("fs.hdfs.impl", org.apache.hadoop.hdfs.DistributedFileSystem.class.getName());
Review comment:
this is some old old code. Have you ensured that this can run on a non HDFS filesystem now? (HDFS is testing in unit and integration tests already)
##########
File path: hudi-common/pom.xml
##########
@@ -144,6 +144,7 @@
<artifactId>*</artifactId>
</exclusion>
</exclusions>
+ <scope>provided</scope>
Review comment:
I think so. We explicitly whitelist in bundles anwyay, so does not matter
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org