You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@apr.apache.org by bu...@apache.org on 2012/08/09 21:40:45 UTC
[Bug 53689] New: apr_dbd_prepare should pass offsets to the drivers'
prepare-functions
https://issues.apache.org/bugzilla/show_bug.cgi?id=53689
Priority: P2
Bug ID: 53689
Assignee: bugs@apr.apache.org
Summary: apr_dbd_prepare should pass offsets to the drivers'
prepare-functions
Severity: normal
Classification: Unclassified
OS: FreeBSD
Reporter: mi+apache@aldan.algebra.com
Hardware: PC
Status: NEW
Version: HEAD
Component: APR-util
Product: APR
Created attachment 29202
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29202&action=edit
Alter the "prepare" API call to pass offsets found by apr_dbd_prepare to the
drivers
While trying to fix the FreeTDS driver (see Bug 53666), it occurred to me, that
-- because the work of parsing the statement-templates is already done by the
global apr_dbd_prepare() -- the function should share its findings with the
drivers' prepare-calls.
FreeTDS would certainly benefit from it, while others will not be hurt -- there
need not be an ABI change and the existing drivers will not need recompiling.
A brief discussion with bojan@ revealed, that he is hesitant to change the API,
which is understandable. I, however, believe, that the change's usefulness
makes it worthwhile.
The argument, that the list of offsets would only be useful to FreeTDS is
countered by the fact, that "label" is ignored by most drivers too.
Though I'm submitting a patch for Bug 53666 fixing FreeTDS-driver without this
change, I'd much rather avoid the work-duplication and hackery involved in
reparsing the string, that was already processed above...
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org
[Bug 53689] apr_dbd_prepare should pass offsets to the drivers'
prepare-functions
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53689
Mikhail T. <mi...@aldan.algebra.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #29202|0 |1
is patch| |
--- Comment #1 from Mikhail T. <mi...@aldan.algebra.com> ---
Comment on attachment 29202
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29202
Alter the "prepare" API call to pass offsets found by apr_dbd_prepare to the
drivers
If need be, the creation and population of the proposed offsets-array can be
made conditional on driver->pformat being empty...
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org