[GitHub] [spark] cloud-fan commented on a change in pull request #34137: [SPARK-36588] Migrate SHOW TABLES to use V2 command by default

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #34137:
URL: https://github.com/apache/spark/pull/34137#discussion_r718282534



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExec.scala
##########
@@ -33,7 +33,8 @@ case class ShowTablesExec(
     output: Seq[Attribute],
     catalog: TableCatalog,
     namespace: Seq[String],
-    pattern: Option[String]) extends V2CommandExec with LeafExecNode {
+    pattern: Option[String],
+    listTempViews: Option[String] => Seq[Identifier]) extends V2CommandExec with LeafExecNode {

Review comment:
       do we need to pass this? All `SparkPlan` can access the current spark session by calling `this.session`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org