You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/01/10 00:41:47 UTC

[Impala-ASF-CR] Add doc for MT DOP query option.

John Russell has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5652

Change subject: Add doc for MT_DOP query option.
......................................................................

Add doc for MT_DOP query option.

Change-Id: Ife2786532b425af6d230074f1c0b5c7dcb2b8a92
---
M docs/impala.ditamap
M docs/shared/impala_common.xml
A docs/topics/impala_mt_dop.xml
3 files changed, 61 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/5652/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife2786532b425af6d230074f1c0b5c7dcb2b8a92
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>

[Impala-ASF-CR] [DOCS] Add doc for MT DOP query option.

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.

Change subject: [DOCS] Add doc for MT_DOP query option.
......................................................................


Patch Set 5: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife2786532b425af6d230074f1c0b5c7dcb2b8a92
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] [DOCS] Add doc for MT DOP query option.

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#5).

Change subject: [DOCS] Add doc for MT_DOP query option.
......................................................................

[DOCS] Add doc for MT_DOP query option.

Add info about MT_DOP default to COMPUTE STATS.

Change-Id: Ife2786532b425af6d230074f1c0b5c7dcb2b8a92
---
M docs/impala.ditamap
M docs/impala_keydefs.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_compute_stats.xml
A docs/topics/impala_mt_dop.xml
5 files changed, 223 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/5652/5
-- 
To view, visit http://gerrit.cloudera.org:8080/5652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ife2786532b425af6d230074f1c0b5c7dcb2b8a92
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] [DOCS] Add doc for MT DOP query option.

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.

Change subject: [DOCS] Add doc for MT_DOP query option.
......................................................................


Patch Set 4:

(6 comments)

I made comments for changes based on discussion with Mostafa.

http://gerrit.cloudera.org:8080/#/c/5652/4/docs/topics/impala_mt_dop.xml
File docs/topics/impala_mt_dop.xml:

PS4, Line 94: These timing figures
Reword since I'm going to take out some of the timing figures, so not every example will have 'em.


PS4, Line 100: a speedup for
how to run ... COMPUTE STATS ...

The COUNT(DISTINCT) is in a separate example now so don't mention it here.


PS4, Line 118: Fetched 1 row(s) in 7.55s
Mostafa suggestion: Take out timing info.


PS4, Line 122: cores
Mostafa suggestion: "logical processors"


PS4, Line 132: Fetched 1 row(s) in 4.53s
Mostafa suggestion: Take out timing info.


PS4, Line 148: Fetched 1 row(s) in 4.53s
Mostafa suggestion: Take out timing info.


-- 
To view, visit http://gerrit.cloudera.org:8080/5652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife2786532b425af6d230074f1c0b5c7dcb2b8a92
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] [DOCS] Add doc for MT DOP query option.

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#4).

Change subject: [DOCS] Add doc for MT_DOP query option.
......................................................................

[DOCS] Add doc for MT_DOP query option.

Add info about MT_DOP default to COMPUTE STATS.

Change-Id: Ife2786532b425af6d230074f1c0b5c7dcb2b8a92
---
M docs/impala.ditamap
M docs/impala_keydefs.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_compute_stats.xml
A docs/topics/impala_mt_dop.xml
5 files changed, 225 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/5652/4
-- 
To view, visit http://gerrit.cloudera.org:8080/5652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ife2786532b425af6d230074f1c0b5c7dcb2b8a92
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] Add doc for MT DOP query option.

Posted by "Mostafa Mokhtar (Code Review)" <ge...@cloudera.org>.
Mostafa Mokhtar has posted comments on this change.

Change subject: Add doc for MT_DOP query option.
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5652/1/docs/topics/impala_mt_dop.xml
File docs/topics/impala_mt_dop.xml:

Line 39:       Sets the degree of parallelism used for certain operations that
Should we mention the operations where mt_dop applies?
Compute stats and queries that have scan and aggregate only operators?


Line 42:       and increased memory and CPU usage during statement processing.
I would reword to "ideal balance between response time, memory and CPU". 
As some operations like "compute stats" consume less overall memory due to running with less scanner threads.


-- 
To view, visit http://gerrit.cloudera.org:8080/5652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife2786532b425af6d230074f1c0b5c7dcb2b8a92
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] Add doc for MT DOP query option.

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.

Change subject: Add doc for MT_DOP query option.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5652/1/docs/topics/impala_mt_dop.xml
File docs/topics/impala_mt_dop.xml:

Line 43:     </p>
I think it would make sense to document (for now) that many queries don't support mt_dop, so that users aren't surprised to get an error after setting it. E.g. 

[localhost:21000] > set mt_dop=1;
MT_DOP set to 1
[localhost:21000] > select * from functional.alltypes a1 inner join functional.alltypes a2 on a1.id = a2.id limit 4;
Query: select * from functional.alltypes a1 inner join functional.alltypes a2 on a1.id = a2.id limit 4
Query submitted at: 2017-01-18 14:49:46 (Coordinator: http://tarmstrong-box:25000)
ERROR: NotImplementedException: MT_DOP not supported for plans with base table joins or table sinks.


-- 
To view, visit http://gerrit.cloudera.org:8080/5652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife2786532b425af6d230074f1c0b5c7dcb2b8a92
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] [DOCS] Add doc for MT DOP query option.

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.

Change subject: [DOCS] Add doc for MT_DOP query option.
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5652/3/docs/topics/impala_mt_dop.xml
File docs/topics/impala_mt_dop.xml:

Line 39:       Sets the degree of parallelism used for certain operations that
of intra-node parallelism


Line 67:             Queries with execution plans containing only scan and aggregation operators.
or local joins that do not need data exchanges (e.g. for nested types)


-- 
To view, visit http://gerrit.cloudera.org:8080/5652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife2786532b425af6d230074f1c0b5c7dcb2b8a92
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] [DOCS] Add doc for MT DOP query option.

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.

Change subject: [DOCS] Add doc for MT_DOP query option.
......................................................................


Patch Set 5:

(6 comments)

Addressed all comments.

http://gerrit.cloudera.org:8080/#/c/5652/4/docs/topics/impala_mt_dop.xml
File docs/topics/impala_mt_dop.xml:

PS4, Line 94: Any timing figures i
> Reword since I'm going to take out some of the timing figures, so not every
Done


PS4, Line 100: 
> how to run ... COMPUTE STATS ...
Done


PS4, Line 118: +------------------------
> Mostafa suggestion: Take out timing info.
Done


PS4, Line 122: logic
> Mostafa suggestion: "logical processors"
Done


PS4, Line 132: 
> Mostafa suggestion: Take out timing info.
Done


PS4, Line 148: </codeblock>
> Mostafa suggestion: Take out timing info.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife2786532b425af6d230074f1c0b5c7dcb2b8a92
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] Add doc for MT DOP query option.

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#2).

Change subject: Add doc for MT_DOP query option.
......................................................................

Add doc for MT_DOP query option.

Change-Id: Ife2786532b425af6d230074f1c0b5c7dcb2b8a92
---
M docs/impala.ditamap
M docs/impala_keydefs.ditamap
M docs/shared/impala_common.xml
A docs/topics/impala_mt_dop.xml
4 files changed, 215 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/5652/2
-- 
To view, visit http://gerrit.cloudera.org:8080/5652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ife2786532b425af6d230074f1c0b5c7dcb2b8a92
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] [DOCS] Add doc for MT DOP query option.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: [DOCS] Add doc for MT_DOP query option.
......................................................................


Patch Set 5:

Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/28/

-- 
To view, visit http://gerrit.cloudera.org:8080/5652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife2786532b425af6d230074f1c0b5c7dcb2b8a92
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] [DOCS] Add doc for MT DOP query option.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: [DOCS] Add doc for MT_DOP query option.
......................................................................


Patch Set 5: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/5652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife2786532b425af6d230074f1c0b5c7dcb2b8a92
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] [DOCS] Add doc for MT DOP query option.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.

Change subject: [DOCS] Add doc for MT_DOP query option.
......................................................................


[DOCS] Add doc for MT_DOP query option.

Add info about MT_DOP default to COMPUTE STATS.

Change-Id: Ife2786532b425af6d230074f1c0b5c7dcb2b8a92
Reviewed-on: http://gerrit.cloudera.org:8080/5652
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/impala.ditamap
M docs/impala_keydefs.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_compute_stats.xml
A docs/topics/impala_mt_dop.xml
5 files changed, 223 insertions(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Verified
  Alex Behm: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/5652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ife2786532b425af6d230074f1c0b5c7dcb2b8a92
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] Add doc for MT DOP query option.

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.

Change subject: Add doc for MT_DOP query option.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5652/1/docs/topics/impala_mt_dop.xml
File docs/topics/impala_mt_dop.xml:

Line 38:       <indexterm audience="hidden">MT_DOP query option</indexterm>
We should mention somewhere that COMPUTE [INCREMENTAL] STATS on Parquet tables is run with MT_DOP=4 by default.

We should also clarify the special meaning of MT_DOP=0, this might need a brief introduction to our multi-threading effort, i.e. that we are incrementally revamping the execution engine, and MT_DOP=0 will revert to using the "old" execution engine.


-- 
To view, visit http://gerrit.cloudera.org:8080/5652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife2786532b425af6d230074f1c0b5c7dcb2b8a92
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] [DOCS] Add doc for MT DOP query option.

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.

Change subject: [DOCS] Add doc for MT_DOP query option.
......................................................................


Patch Set 4:

(6 comments)

Addressed comments.

http://gerrit.cloudera.org:8080/#/c/5652/1/docs/topics/impala_mt_dop.xml
File docs/topics/impala_mt_dop.xml:

Line 38:       <indexterm audience="hidden">MT_DOP query option</indexterm>
> We should mention somewhere that COMPUTE [INCREMENTAL] STATS on Parquet tab
Done


Line 39:       Sets the degree of intra-node parallelism used for certain operations that
> Should we mention the operations where mt_dop applies?
Done


Line 42:       memory usage, and CPU usage during statement processing.
> I would reword to "ideal balance between response time, memory and CPU". 
Done


Line 43:     </p>
> I think it would make sense to document (for now) that many queries don't s
Done


http://gerrit.cloudera.org:8080/#/c/5652/3/docs/topics/impala_mt_dop.xml
File docs/topics/impala_mt_dop.xml:

Line 39:       Sets the degree of intra-node parallelism used for certain operations that
> of intra-node parallelism
Done


Line 67:             Queries with execution plans containing only scan and aggregation operators,
> or local joins that do not need data exchanges (e.g. for nested types)
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife2786532b425af6d230074f1c0b5c7dcb2b8a92
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] [DOCS] Add doc for MT DOP query option.

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#3).

Change subject: [DOCS] Add doc for MT_DOP query option.
......................................................................

[DOCS] Add doc for MT_DOP query option.

Add info about MT_DOP default to COMPUTE STATS.

Change-Id: Ife2786532b425af6d230074f1c0b5c7dcb2b8a92
---
M docs/impala.ditamap
M docs/impala_keydefs.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_compute_stats.xml
A docs/topics/impala_mt_dop.xml
5 files changed, 224 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/5652/3
-- 
To view, visit http://gerrit.cloudera.org:8080/5652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ife2786532b425af6d230074f1c0b5c7dcb2b8a92
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>