You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/07/11 13:49:17 UTC
[GitHub] [superset] diegomedina248 opened a new pull request, #20670: feat: Add resize drag handle to Dataset SQL fields
diegomedina248 opened a new pull request, #20670:
URL: https://github.com/apache/superset/pull/20670
### SUMMARY
The SQL Editor in the Dataset modal doesn't have an option to resize.
Specially in the Metrics column, the field is way too small.
This PR enables resize in those fields.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Resize changes:
https://user-images.githubusercontent.com/17252075/178278836-ab5f630a-7d8d-47f4-93a6-479633457965.mov
### TESTING INSTRUCTIONS
Open the edit modal for a physical dataset and virtual dataset.
Ensure editor fields can be resized.
### ADDITIONAL INFORMATION
Closes #20200, #14794
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #20670: feat: Add resize drag handle to Dataset SQL fields
Posted by GitBox <gi...@apache.org>.
rusackas merged PR #20670:
URL: https://github.com/apache/superset/pull/20670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #20670: feat: Add resize drag handle to Dataset SQL fields
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on PR #20670:
URL: https://github.com/apache/superset/pull/20670#issuecomment-1183956570
@diegomedina248 should rebase master to get rid of coverage failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Antonio-RiveroMartnez commented on a diff in pull request #20670: feat: Add resize drag handle to Dataset SQL fields
Posted by GitBox <gi...@apache.org>.
Antonio-RiveroMartnez commented on code in PR #20670:
URL: https://github.com/apache/superset/pull/20670#discussion_r918088338
##########
superset-frontend/src/explore/components/controls/TextAreaControl.jsx:
##########
@@ -55,6 +65,8 @@ const defaultProps = {
maxLines: 10,
offerEditInModal: true,
readOnly: false,
+ resize: false,
Review Comment:
`resize` is not of type `boolean` from the declaration above.
##########
superset-frontend/src/explore/components/controls/TextAreaControl.jsx:
##########
@@ -45,6 +45,16 @@ const propTypes = {
]),
aboveEditorSection: PropTypes.node,
readOnly: PropTypes.bool,
+ resize: PropTypes.oneOf([
+ null,
Review Comment:
Are `null` and `none` the same?
##########
superset-frontend/src/components/Datasource/CollectionTable.tsx:
##########
@@ -335,6 +343,13 @@ export default class CRUDCollection extends React.PureComponent<
);
}
+ getCellProps(record: any, col: any) {
+ const cellPropsFn =
+ this.props.itemCellProps && this.props.itemCellProps[col];
Review Comment:
`this.props.itemCellProps?.[col]` vs `this.props.itemCellProps && this.props.itemCellProps[col];` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] diegomedina248 commented on a diff in pull request #20670: feat: Add resize drag handle to Dataset SQL fields
Posted by GitBox <gi...@apache.org>.
diegomedina248 commented on code in PR #20670:
URL: https://github.com/apache/superset/pull/20670#discussion_r918104185
##########
superset-frontend/src/explore/components/controls/TextAreaControl.jsx:
##########
@@ -45,6 +45,16 @@ const propTypes = {
]),
aboveEditorSection: PropTypes.node,
readOnly: PropTypes.bool,
+ resize: PropTypes.oneOf([
+ null,
Review Comment:
not necessarily, cause `none` will actually set the css, whereas null will do nothing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #20670: feat: Add resize drag handle to Dataset SQL fields
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on PR #20670:
URL: https://github.com/apache/superset/pull/20670#issuecomment-1184112902
@diegomedina248 the master branch has a failure integration test, I have skipped it on the latest [commit](https://github.com/apache/superset/pull/20699/files#r920823022), and will fix it in separated pr. please rebase again. sorry for the multiple rebases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #20670: feat: Add resize drag handle to Dataset SQL fields
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #20670:
URL: https://github.com/apache/superset/pull/20670#issuecomment-1180517630
# [Codecov](https://codecov.io/gh/apache/superset/pull/20670?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20670](https://codecov.io/gh/apache/superset/pull/20670?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5adcc30) into [master](https://codecov.io/gh/apache/superset/commit/0a316a8ed324ecc46372a03a47cb5f2474e7b349?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0a316a8) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #20670 +/- ##
=======================================
Coverage 66.74% 66.75%
=======================================
Files 1753 1753
Lines 65823 65829 +6
Branches 7007 7010 +3
=======================================
+ Hits 43936 43942 +6
Misses 20101 20101
Partials 1786 1786
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.95% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/20670?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tend/src/components/Datasource/CollectionTable.tsx](https://codecov.io/gh/apache/superset/pull/20670/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YXNvdXJjZS9Db2xsZWN0aW9uVGFibGUudHN4) | `81.35% <100.00%> (+0.48%)` | :arrow_up: |
| [...end/src/components/Datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/20670/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YXNvdXJjZS9EYXRhc291cmNlRWRpdG9yLmpzeA==) | `65.87% <100.00%> (+0.13%)` | :arrow_up: |
| [...rc/explore/components/controls/TextAreaControl.jsx](https://codecov.io/gh/apache/superset/pull/20670/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0QXJlYUNvbnRyb2wuanN4) | `81.81% <100.00%> (+1.81%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/20670?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/20670?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0a316a8...5adcc30](https://codecov.io/gh/apache/superset/pull/20670?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org