You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "zuston (via GitHub)" <gi...@apache.org> on 2024/08/22 11:57:12 UTC

Re: [PR] [#2061]fix(server): Fix netty memory leak when removeBuffer and cacheShuffle… [incubator-uniffle]

zuston commented on code in PR #2059:
URL: https://github.com/apache/incubator-uniffle/pull/2059#discussion_r1726917433


##########
server/src/main/java/org/apache/uniffle/server/buffer/AbstractShuffleBuffer.java:
##########
@@ -41,8 +41,12 @@ public abstract class AbstractShuffleBuffer implements ShuffleBuffer {
 
   protected long size;
 
+  protected volatile boolean closed;

Review Comment:
   the naming of closed sounds weired to me. How about dropped? or evicted? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org