You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by sjcorbett <gi...@git.apache.org> on 2015/12/17 13:23:56 UTC

[GitHub] incubator-brooklyn pull request: Downstream-parent / OSGi

GitHub user sjcorbett opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/1114

    Downstream-parent / OSGi

    Removes the `Export-Package` manifest configuration from `brooklyn-downstream-parent` and adds a number of excludes of packages that are not bundles to `Import-Package`. 
    
    Projects using downstream-parent can be loaded into catalogues via bundles by default. This can be tested by running `DownstreamParentTest` in the QA module.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sjcorbett/incubator-brooklyn fix/downstream-parent-osgi

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/1114.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1114
    
----
commit 975be037b397eee2d53730752b80ee49483f308e
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Date:   2015-12-16T11:27:24Z

    Forbid all imports from com.google.api.client
    
    Rather than com.google.api.client.repackaged.

commit ececc89e09faf719b38f9b5e752e2c842b507958
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Date:   2015-12-16T14:38:11Z

    downstream-parent does not set Export-Package
    
    There's no need for a downstream project to automatically export
    brooklyn.* and org.apache.brooklyn.* and it causes a number of issues
    when loading bundles into catalogues.

commit 98e4af60786cf3783549f7a13e4dafa3548c951b
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Date:   2015-12-16T14:38:56Z

    downstream-parent excludes a number of non-OSGi packages
    
    All of them can break catalogue loading.

commit ccdb18183f68288bb150fd4fb9a9c51ea6aca547
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Date:   2015-12-17T12:20:10Z

    Test loading downstream-project into catalogue
    
    Acceptance test that auto-checks whether projects using
    downstream-parent will work when loaded from bundle libraries rather
    than the classpath.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Downstream-parent / OSGi

Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1114#issuecomment-166279378
  
    looks good, testing then will merge


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Downstream-parent / OSGi

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/1114


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---