[GitHub] [cloudstack] pbankonier commented on issue #3434: Build css from scss sources in client ui build

[GitBox <gi...@apache.org>]

pbankonier commented on issue #3434: Build css from scss sources in client ui build
URL: https://github.com/apache/cloudstack/pull/3434#issuecomment-508055720
 
 
   @rhtyd That these css files get finally removed is just a consequence from this change https://github.com/apache/cloudstack/pull/3307. The css files should not be edited nonetheless right now, because they get build from the scss sources. So the css files should have been removed already in that PR. Everyone who wants to make a styling change should edit the scss files and then build the css from them. Normally you would not keep the css files in the repo, because have redundant information regarding the scss files, so when someone changes one without the other we will get an inconsistent state of these files, which results in the necessity of someone keeping them in sync manually.
   So to prevent this it is important to get this change merged, which compiles the scss files to css during the build of the module and removes the responsibility for keeping these files in sync from the devs. There is no impact in the usage.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services