You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/11/14 08:54:40 UTC
[GitHub] [tvm] alter-xp opened a new pull request, #13366: [ci] fix GPU other build
alter-xp opened a new pull request, #13366:
URL: https://github.com/apache/tvm/pull/13366
Related pr https://github.com/apache/tvm/pull/13235, https://github.com/apache/tvm/issues/12777,https://github.com/apache/tvm/pull/13261
because of ROCM build faild, pr https://github.com/apache/tvm/pull/13235 destroyed CI.
this pr fixed that bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] alter-xp commented on pull request #13366: [ci] fix GPU other build
Posted by GitBox <gi...@apache.org>.
alter-xp commented on PR #13366:
URL: https://github.com/apache/tvm/pull/13366#issuecomment-1315249832
hi @driazati, could you help me look at this CI report?
https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/fix_gpu_other_build/1/pipeline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on a diff in pull request #13366: [ci] fix GPU other build
Posted by GitBox <gi...@apache.org>.
driazati commented on code in PR #13366:
URL: https://github.com/apache/tvm/pull/13366#discussion_r1023417800
##########
ci/jenkins/Build.groovy.j2:
##########
@@ -21,7 +21,7 @@ def fsim_test(image) {
def cmake_build(image, path, make_flag) {
sh (
- script: "${docker_run} --env CI_NUM_EXECUTORS ${image} ./tests/scripts/task_build.py --sccache-bucket tvm-sccache-prod",
+ script: "${docker_run} --env CI_NUM_EXECUTORS ${image} ./tests/scripts/task_build.py --sccache-bucket tvm-sccache-prod --build-dir ${path}",
Review Comment:
Actually this seems more broken than I initially thought, what do you think about just fixing the build with the `rocm_device_api.cc` change and reverting the `Build.groovy.j2` changes? https://github.com/apache/tvm/pull/13335/files#r1023416998 will fix up the infra to make things work then we can iterate on actually fixing the full build + test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on a diff in pull request #13366: [ci] fix GPU other build
Posted by GitBox <gi...@apache.org>.
driazati commented on code in PR #13366:
URL: https://github.com/apache/tvm/pull/13366#discussion_r1023139360
##########
ci/jenkins/Build.groovy.j2:
##########
@@ -93,9 +93,9 @@ stage('Build') {
{{ m.upload_artifacts(tag='gpu', filenames=tvm_multilib, folders=microtvm_template_projects) }}
// compiler test
- sh "${docker_run} --no-gpu ${ci_gpu} ./tests/scripts/task_config_build_gpu_other.sh build2"
- make("${ci_gpu} --no-gpu", 'build2', '-j2')
- {{ m.upload_artifacts(tag='gpu2', filenames=tvm_multilib) }}
+ sh "${docker_run} --no-gpu ${ci_gpu} ./tests/scripts/task_clean.sh build",
Review Comment:
I think the very unhelpful Jenkins error [here](https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/fix_gpu_other_build/1/pipeline/#step-377-log-77) is actually complaining about this comma
```suggestion
sh "${docker_run} --no-gpu ${ci_gpu} ./tests/scripts/task_clean.sh build"
```
edit: since I have to push the branch to apache/tvm anyways I pushed this edit, hopefully it works
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] alter-xp commented on a diff in pull request #13366: [ci] fix GPU other build
Posted by GitBox <gi...@apache.org>.
alter-xp commented on code in PR #13366:
URL: https://github.com/apache/tvm/pull/13366#discussion_r1023419852
##########
ci/jenkins/Build.groovy.j2:
##########
@@ -21,7 +21,7 @@ def fsim_test(image) {
def cmake_build(image, path, make_flag) {
sh (
- script: "${docker_run} --env CI_NUM_EXECUTORS ${image} ./tests/scripts/task_build.py --sccache-bucket tvm-sccache-prod",
+ script: "${docker_run} --env CI_NUM_EXECUTORS ${image} ./tests/scripts/task_build.py --sccache-bucket tvm-sccache-prod --build-dir ${path}",
Review Comment:
No problem~ thank you very much for your help!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on a diff in pull request #13366: [ci] fix GPU other build
Posted by GitBox <gi...@apache.org>.
driazati commented on code in PR #13366:
URL: https://github.com/apache/tvm/pull/13366#discussion_r1023139360
##########
ci/jenkins/Build.groovy.j2:
##########
@@ -93,9 +93,9 @@ stage('Build') {
{{ m.upload_artifacts(tag='gpu', filenames=tvm_multilib, folders=microtvm_template_projects) }}
// compiler test
- sh "${docker_run} --no-gpu ${ci_gpu} ./tests/scripts/task_config_build_gpu_other.sh build2"
- make("${ci_gpu} --no-gpu", 'build2', '-j2')
- {{ m.upload_artifacts(tag='gpu2', filenames=tvm_multilib) }}
+ sh "${docker_run} --no-gpu ${ci_gpu} ./tests/scripts/task_clean.sh build",
Review Comment:
I think the very unhelpful Jenkins error [here](https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/fix_gpu_other_build/1/pipeline/#step-377-log-77) is actually complaining about this comma
```suggestion
sh "${docker_run} --no-gpu ${ci_gpu} ./tests/scripts/task_clean.sh build"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #13366: [ci] fix GPU other build
Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13366:
URL: https://github.com/apache/tvm/pull/13366#issuecomment-1313308512
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* cc @Mousius, @areusch, @driazati, @gigiblender <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati merged pull request #13366: [ci] fix GPU other build
Posted by GitBox <gi...@apache.org>.
driazati merged PR #13366:
URL: https://github.com/apache/tvm/pull/13366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org