You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by Andre Fischer <af...@a-w-f.de> on 2011/11/18 15:42:58 UTC
[CODE] issue 118604 - IP clearance: Remove dmake source
Hi all,
finished the work on removing the local dmake source code.
dmake can now come from one of three different locations:
1. Pre-installed executable in the system search path. This is detected
automatically by configure. No additional option required.
2. Executable in a non-standard location. Use the
--with-dmake-path=<path-to-executable> option to specify its location.
3. A source tar-ball somewhere on the internet. Use
--with-dmake-url=<url-of-tarball> to specify its location. It is then
downloaded and built by the bootstrap script.
See issue 118604 (https://issues.apache.org/ooo/show_bug.cgi?id=118604)
for more details and the patches.
There are two patches in four files (I had to split the second patch
into chunks smaller than 1MB due size limits on file uploads.) The first
introduces the new options, the second removes the dmake source code,
but you will want to apply both.
Tested on Windows, Linux, and Mac, but reviews are still welcome.
It would also be nice, if somebody has the courage to integrate it.
Thanks,
Andre
Re: [CODE] issue 118604 - IP clearance: Remove dmake source
Posted by Jürgen Schmidt <jo...@googlemail.com>.
On 11/18/11 3:52 PM, Jürgen Schmidt wrote:
> On 11/18/11 3:42 PM, Andre Fischer wrote:
>> Hi all,
>>
>> finished the work on removing the local dmake source code.
>>
>> dmake can now come from one of three different locations:
>>
>> 1. Pre-installed executable in the system search path. This is detected
>> automatically by configure. No additional option required.
>>
>> 2. Executable in a non-standard location. Use the
>> --with-dmake-path=<path-to-executable> option to specify its location.
>>
>> 3. A source tar-ball somewhere on the internet. Use
>> --with-dmake-url=<url-of-tarball> to specify its location. It is then
>> downloaded and built by the bootstrap script.
>>
>>
>> See issue 118604 (https://issues.apache.org/ooo/show_bug.cgi?id=118604)
>> for more details and the patches.
>>
>> There are two patches in four files (I had to split the second patch
>> into chunks smaller than 1MB due size limits on file uploads.) The first
>> introduces the new options, the second removes the dmake source code,
>> but you will want to apply both.
>>
>> Tested on Windows, Linux, and Mac, but reviews are still welcome.
>>
>> It would also be nice, if somebody has the courage to integrate it.
>
> i will check it ...
done, http://svn.apache.org/viewvc?rev=1204412&view=rev
Again, thanks André
Juergen
Re: [CODE] issue 118604 - IP clearance: Remove dmake source
Posted by Jürgen Schmidt <jo...@googlemail.com>.
On 11/18/11 3:42 PM, Andre Fischer wrote:
> Hi all,
>
> finished the work on removing the local dmake source code.
>
> dmake can now come from one of three different locations:
>
> 1. Pre-installed executable in the system search path. This is detected
> automatically by configure. No additional option required.
>
> 2. Executable in a non-standard location. Use the
> --with-dmake-path=<path-to-executable> option to specify its location.
>
> 3. A source tar-ball somewhere on the internet. Use
> --with-dmake-url=<url-of-tarball> to specify its location. It is then
> downloaded and built by the bootstrap script.
>
>
> See issue 118604 (https://issues.apache.org/ooo/show_bug.cgi?id=118604)
> for more details and the patches.
>
> There are two patches in four files (I had to split the second patch
> into chunks smaller than 1MB due size limits on file uploads.) The first
> introduces the new options, the second removes the dmake source code,
> but you will want to apply both.
>
> Tested on Windows, Linux, and Mac, but reviews are still welcome.
>
> It would also be nice, if somebody has the courage to integrate it.
i will check it ...
Juergen
Re: [CODE] issue 118604 - IP clearance: Remove dmake source
Posted by Ariel Constenla-Haile <ar...@apache.org>.
Hi Andre,
On Wed, Nov 23, 2011 at 05:39:14PM +0100, Andre Fischer wrote:
> I added another patch to issue 118604 that fixes this. I just
> became committer (yay)
congratulations :)
> but I am still sorting out the technical
> details of how to actually commit code. So for the time being I
> still have to ask for somebody else to do that.
done, committed as r1205544.
Regards
--
Ariel Constenla-Haile
La Plata, Argentina
Re: [CODE] issue 118604 - IP clearance: Remove dmake source
Posted by Andre Fischer <af...@a-w-f.de>.
Hi,
Sorry about that. Looks like I did not test the case of a user supplied
dmake executable well enough (I probably had a dmake in my search path
that was found when all else failed.)
I added another patch to issue 118604 that fixes this. I just became
committer (yay) but I am still sorting out the technical details of how
to actually commit code. So for the time being I still have to ask for
somebody else to do that.
Regards,
Andre
On 23.11.2011 00:09, Ariel Constenla-Haile wrote:
>
> Hi all,
>
> On Fri, Nov 18, 2011 at 03:42:58PM +0100, Andre Fischer wrote:
>>
>> 2. Executable in a non-standard location. Use the
>> --with-dmake-path=<path-to-executable> option to specify its
>> location.
>
> I couldn't make this work (tested on Fedora and Win/cygwin).
> I tried
>
> --with-dmake-path=/home/ariel/src/devel/dmake/INST/bin
> --with-dmake-path=/home/ariel/src/devel/dmake/INST/bin/dmake
> --with-dmake-path=/home/ariel/src/devel/dmake/INST/bin/
> etc.
>
> and I get always
>
> checking for dmake... checking for dmake... no
> checking for dmake... (cached) no
> configure: no system or user-provided dmake found
> configure: WARNING: no URL for dmake source code specified, either.
> configure: WARNING: dmake will be built from internal sources but these
> will be removed in the future"
> configure: error: please use --with-dmake-path or --with-dmake-url to
> specify dmake executable or source
>
>
> I gave up and placed dmake in ~/bin
> Any idea how to make it work?
>
>
> Regards
Re: [CODE] issue 118604 - IP clearance: Remove dmake source
Posted by Ariel Constenla-Haile <ar...@apache.org>.
Hi all,
On Fri, Nov 18, 2011 at 03:42:58PM +0100, Andre Fischer wrote:
>
> 2. Executable in a non-standard location. Use the
> --with-dmake-path=<path-to-executable> option to specify its
> location.
I couldn't make this work (tested on Fedora and Win/cygwin).
I tried
--with-dmake-path=/home/ariel/src/devel/dmake/INST/bin
--with-dmake-path=/home/ariel/src/devel/dmake/INST/bin/dmake
--with-dmake-path=/home/ariel/src/devel/dmake/INST/bin/
etc.
and I get always
checking for dmake... checking for dmake... no
checking for dmake... (cached) no
configure: no system or user-provided dmake found
configure: WARNING: no URL for dmake source code specified, either.
configure: WARNING: dmake will be built from internal sources but these
will be removed in the future"
configure: error: please use --with-dmake-path or --with-dmake-url to
specify dmake executable or source
I gave up and placed dmake in ~/bin
Any idea how to make it work?
Regards
--
Ariel Constenla-Haile
La Plata, Argentina