You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "Dave Thompson (Jira)" <ji...@apache.org> on 2023/01/24 17:34:00 UTC

[jira] [Closed] (DAFFODIL-2772) Eliminate CLI it:test target and src/it directory in favor of ordinary src/test

     [ https://issues.apache.org/jira/browse/DAFFODIL-2772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dave Thompson closed DAFFODIL-2772.
-----------------------------------

Verified the specified commit (commit 14f9fbedf2846242cd16d4e0eabac32fb4457623) is included in the latest pull from the daffodil repository.

Verified, via review, changes identified in the ticket and commit comment was implemented.

Verified cli test folders/files moved from daffodil-cli/src/it to daffodil-cli/src/test. 

Verified udf test folders/files remain under daffodil-cli/src/it.

Verified the daffodil-cli subproject sbt test suite now executes successfully under daffodil-cli/test.

Verified the daffodil-udf subproject sbt test suite still executes successfully under daffodil-cli/it:test.

> Eliminate CLI it:test target and src/it directory in favor of ordinary src/test
> -------------------------------------------------------------------------------
>
>                 Key: DAFFODIL-2772
>                 URL: https://issues.apache.org/jira/browse/DAFFODIL-2772
>             Project: Daffodil
>          Issue Type: Improvement
>          Components: Infrastructure
>    Affects Versions: 3.4.0
>            Reporter: Mike Beckerle
>            Assignee: Mike Beckerle
>            Priority: Major
>             Fix For: 3.5.0
>
>
>  
> Our CLI integration tests run much faster now. 
> The reason for this separate 'sbt it:test' thing are gone. 
> Having a separate src/it directory causes trouble for tooling. E.g., I find I have to rename any existing src/test directory to src/test1, then rename src/it to src/test in order to run the CLI tests from the normal JUnit type IDE support features. This is too clumsy. 
> We should switch back to just having the CLI tests live in src/test and have them run the ordinary way via 'sbt test'. After all there's only 267 of them, whereas there are 4000+ tests in the regular daffodil 'sbt test' suite. 
> I would like to eliminate the creation of the scaladoc/javadoc, jars, etc. as part of building the CLI also, as there is no point in waiting for that to run the basic set of CLI tests. 
> If there are CLI tests which really depend on being able to fork and exec an executable, those can stay under src/it, but I think the vast bulk of the CLI tests should just become regular src/test/scala tests which are far easier to run. 
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)