You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by ch...@apache.org on 2016/11/17 05:11:18 UTC
svn commit: r1770121 -
/sling/trunk/bundles/commons/metrics/src/main/java/org/apache/sling/commons/metrics/internal/BundleMetricsMapper.java
Author: chetanm
Date: Thu Nov 17 05:11:17 2016
New Revision: 1770121
URL: http://svn.apache.org/viewvc?rev=1770121&view=rev
Log:
SLING-5443 - Review the naming conventions used by JMXReporter to register the Metric MBeans
Remove unused instance
Modified:
sling/trunk/bundles/commons/metrics/src/main/java/org/apache/sling/commons/metrics/internal/BundleMetricsMapper.java
Modified: sling/trunk/bundles/commons/metrics/src/main/java/org/apache/sling/commons/metrics/internal/BundleMetricsMapper.java
URL: http://svn.apache.org/viewvc/sling/trunk/bundles/commons/metrics/src/main/java/org/apache/sling/commons/metrics/internal/BundleMetricsMapper.java?rev=1770121&r1=1770120&r2=1770121&view=diff
==============================================================================
--- sling/trunk/bundles/commons/metrics/src/main/java/org/apache/sling/commons/metrics/internal/BundleMetricsMapper.java (original)
+++ sling/trunk/bundles/commons/metrics/src/main/java/org/apache/sling/commons/metrics/internal/BundleMetricsMapper.java Thu Nov 17 05:11:17 2016
@@ -27,7 +27,6 @@ import java.util.concurrent.ConcurrentMa
import javax.management.MalformedObjectNameException;
import javax.management.ObjectName;
-import com.codahale.metrics.DefaultObjectNameFactory;
import com.codahale.metrics.MetricRegistry;
import com.codahale.metrics.ObjectNameFactory;
import org.osgi.framework.Bundle;
@@ -41,7 +40,6 @@ class BundleMetricsMapper implements Obj
private final Logger log = LoggerFactory.getLogger(getClass());
private final ConcurrentMap<String, Bundle> metricToBundleMapping = new ConcurrentHashMap<>();
private final MetricRegistry registry;
- private final ObjectNameFactory defaultFactory = new DefaultObjectNameFactory();
BundleMetricsMapper(MetricRegistry registry) {
this.registry = registry;
@@ -66,7 +64,7 @@ class BundleMetricsMapper implements Obj
mappedDomainName = domain;
}
- Hashtable<String, String> table = new Hashtable<String, String>();
+ Hashtable<String, String> table = new Hashtable<>();
table.put("type", JMX_TYPE_METRICS);
table.put("name", JmxUtil.quoteValueIfRequired(name));
try {