You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/04/07 08:30:31 UTC
[GitHub] [activemq-artemis] brusdev opened a new pull request #3069:
ARTEMIS-2703 Update commons-configuration2 version to 2.7
brusdev opened a new pull request #3069: ARTEMIS-2703 Update commons-configuration2 version to 2.7
URL: https://github.com/apache/activemq-artemis/pull/3069
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] jbonofre commented on a change in pull request
#3069: ARTEMIS-2703 Update commons-configuration2 version to 2.7
Posted by GitBox <gi...@apache.org>.
jbonofre commented on a change in pull request #3069: ARTEMIS-2703 Update commons-configuration2 version to 2.7
URL: https://github.com/apache/activemq-artemis/pull/3069#discussion_r405261617
##########
File path: artemis-features/src/main/resources/features.xml
##########
@@ -63,6 +63,7 @@
<configfile finalname="etc/org.apache.activemq.artemis.cfg">mvn:org.apache.activemq/artemis-features/${pom.version}/cfg</configfile>
<configfile finalname="etc/artemis.xml">mvn:org.apache.activemq/artemis-features/${pom.version}/xml/artemis</configfile>
+ <bundle dependency="true">mvn:javax.mail/mail/1.4.7</bundle>
Review comment:
The problem is on commons-configuration: javax.mail should be an optional import. With updating to commons-configuration 2.7, we have to add a bundle exporting javax.mail package. However, as commons-configuration doesn't define any version range, I would use javax.mail 1.6.2 (recent one) instead of 1.4.7.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] brusdev commented on a change in pull request
#3069: ARTEMIS-2703 Update commons-configuration2 version to 2.7
Posted by GitBox <gi...@apache.org>.
brusdev commented on a change in pull request #3069: ARTEMIS-2703 Update commons-configuration2 version to 2.7
URL: https://github.com/apache/activemq-artemis/pull/3069#discussion_r405367956
##########
File path: artemis-features/src/main/resources/features.xml
##########
@@ -63,6 +63,7 @@
<configfile finalname="etc/org.apache.activemq.artemis.cfg">mvn:org.apache.activemq/artemis-features/${pom.version}/cfg</configfile>
<configfile finalname="etc/artemis.xml">mvn:org.apache.activemq/artemis-features/${pom.version}/xml/artemis</configfile>
+ <bundle dependency="true">mvn:javax.mail/mail/1.4.7</bundle>
Review comment:
@jbonofre thanks for your clarification.
If I replace the bundle `mvn:javax.mail/mail/1.4.7` with `mvn:javax.mail/javax.mail-api/1.6.2` but I get the missing requirement error for the import package: `com.sun.mail.util`.
If I replace the bundle `mvn:javax.mail/mail/1.4.7` with `mvn:com.sun.mail/javax.mail/1.6.2` I don't get any missing requirement error. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull
request #3069: ARTEMIS-2703 Update commons-configuration2 version to 2.7
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on a change in pull request #3069: ARTEMIS-2703 Update commons-configuration2 version to 2.7
URL: https://github.com/apache/activemq-artemis/pull/3069#discussion_r405125549
##########
File path: artemis-features/src/main/resources/features.xml
##########
@@ -63,6 +63,7 @@
<configfile finalname="etc/org.apache.activemq.artemis.cfg">mvn:org.apache.activemq/artemis-features/${pom.version}/cfg</configfile>
<configfile finalname="etc/artemis.xml">mvn:org.apache.activemq/artemis-features/${pom.version}/xml/artemis</configfile>
+ <bundle dependency="true">mvn:javax.mail/mail/1.4.7</bundle>
Review comment:
Lmao agreed , im a pmc and committer and i was even thinking if i missed that our broker had email feature by this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull
request #3069: ARTEMIS-2703 Update commons-configuration2 version to 2.7
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on a change in pull request #3069: ARTEMIS-2703 Update commons-configuration2 version to 2.7
URL: https://github.com/apache/activemq-artemis/pull/3069#discussion_r404868648
##########
File path: artemis-features/src/main/resources/features.xml
##########
@@ -63,6 +63,7 @@
<configfile finalname="etc/org.apache.activemq.artemis.cfg">mvn:org.apache.activemq/artemis-features/${pom.version}/cfg</configfile>
<configfile finalname="etc/artemis.xml">mvn:org.apache.activemq/artemis-features/${pom.version}/xml/artemis</configfile>
+ <bundle dependency="true">mvn:javax.mail/mail/1.4.7</bundle>
Review comment:
javax.mail??/ what's tat?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] asfgit closed pull request #3069: ARTEMIS-2703
Update commons-configuration2 version to 2.7
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3069: ARTEMIS-2703 Update commons-configuration2 version to 2.7
URL: https://github.com/apache/activemq-artemis/pull/3069
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] brusdev commented on a change in pull request
#3069: ARTEMIS-2703 Update commons-configuration2 version to 2.7
Posted by GitBox <gi...@apache.org>.
brusdev commented on a change in pull request #3069: ARTEMIS-2703 Update commons-configuration2 version to 2.7
URL: https://github.com/apache/activemq-artemis/pull/3069#discussion_r404874548
##########
File path: artemis-features/src/main/resources/features.xml
##########
@@ -63,6 +63,7 @@
<configfile finalname="etc/org.apache.activemq.artemis.cfg">mvn:org.apache.activemq/artemis-features/${pom.version}/cfg</configfile>
<configfile finalname="etc/artemis.xml">mvn:org.apache.activemq/artemis-features/${pom.version}/xml/artemis</configfile>
+ <bundle dependency="true">mvn:javax.mail/mail/1.4.7</bundle>
Review comment:
commons-configuration2 2.7 has a new Import-Package in the manifest: javax.mail.internet
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull
request #3069: ARTEMIS-2703 Update commons-configuration2 version to 2.7
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on a change in pull request #3069: ARTEMIS-2703 Update commons-configuration2 version to 2.7
URL: https://github.com/apache/activemq-artemis/pull/3069#discussion_r407514208
##########
File path: artemis-features/src/main/resources/features.xml
##########
@@ -63,6 +63,7 @@
<configfile finalname="etc/org.apache.activemq.artemis.cfg">mvn:org.apache.activemq/artemis-features/${pom.version}/cfg</configfile>
<configfile finalname="etc/artemis.xml">mvn:org.apache.activemq/artemis-features/${pom.version}/xml/artemis</configfile>
+ <bundle dependency="true">mvn:javax.mail/mail/1.4.7</bundle>
Review comment:
if you can't get around.. .add a big comment on why it had to be added... at least we will know.
say we don't use it but for some misconfiguration on the component, we were forced to import it in OSGI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull
request #3069: ARTEMIS-2703 Update commons-configuration2 version to 2.7
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on a change in pull request #3069: ARTEMIS-2703 Update commons-configuration2 version to 2.7
URL: https://github.com/apache/activemq-artemis/pull/3069#discussion_r405125549
##########
File path: artemis-features/src/main/resources/features.xml
##########
@@ -63,6 +63,7 @@
<configfile finalname="etc/org.apache.activemq.artemis.cfg">mvn:org.apache.activemq/artemis-features/${pom.version}/cfg</configfile>
<configfile finalname="etc/artemis.xml">mvn:org.apache.activemq/artemis-features/${pom.version}/xml/artemis</configfile>
+ <bundle dependency="true">mvn:javax.mail/mail/1.4.7</bundle>
Review comment:
Lmao agreed , im a pmc and committer and i was even thinking if i missed that our broker had email feature by this. I was more thinking had someone integrated email alerting for server health issues or something
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull
request #3069: ARTEMIS-2703 Update commons-configuration2 version to 2.7
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on a change in pull request #3069: ARTEMIS-2703 Update commons-configuration2 version to 2.7
URL: https://github.com/apache/activemq-artemis/pull/3069#discussion_r404961447
##########
File path: artemis-features/src/main/resources/features.xml
##########
@@ -63,6 +63,7 @@
<configfile finalname="etc/org.apache.activemq.artemis.cfg">mvn:org.apache.activemq/artemis-features/${pom.version}/cfg</configfile>
<configfile finalname="etc/artemis.xml">mvn:org.apache.activemq/artemis-features/${pom.version}/xml/artemis</configfile>
+ <bundle dependency="true">mvn:javax.mail/mail/1.4.7</bundle>
Review comment:
but we certainly don't expose java mail... is there any way we don't include this? It's weird.
I can foresee people asking how to email messages with artemis.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] brusdev commented on a change in pull request
#3069: ARTEMIS-2703 Update commons-configuration2 version to 2.7
Posted by GitBox <gi...@apache.org>.
brusdev commented on a change in pull request #3069: ARTEMIS-2703 Update commons-configuration2 version to 2.7
URL: https://github.com/apache/activemq-artemis/pull/3069#discussion_r405367956
##########
File path: artemis-features/src/main/resources/features.xml
##########
@@ -63,6 +63,7 @@
<configfile finalname="etc/org.apache.activemq.artemis.cfg">mvn:org.apache.activemq/artemis-features/${pom.version}/cfg</configfile>
<configfile finalname="etc/artemis.xml">mvn:org.apache.activemq/artemis-features/${pom.version}/xml/artemis</configfile>
+ <bundle dependency="true">mvn:javax.mail/mail/1.4.7</bundle>
Review comment:
@jbonofre thanks for your clarification.
If I replace the bundle `mvn:javax.mail/mail/1.4.7` with `mvn:javax.mail/javax.mail-api/1.6.2` I get the missing requirement error for the import package: `com.sun.mail.util`.
If I replace the bundle `mvn:javax.mail/mail/1.4.7` with `mvn:com.sun.mail/javax.mail/1.6.2` I don't get any missing requirement error. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services