[GitHub] [ozone] prashantpogde commented on a diff in pull request #4280: HDDS-7741. [Snapshot] Delete keys in snapshot scope from deleteTable during createSnapshot to accommodate snapshot garbage collection

["prashantpogde (via GitHub)" <gi...@apache.org>]

prashantpogde commented on code in PR #4280:
URL: https://github.com/apache/ozone/pull/4280#discussion_r1119329618


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/snapshot/OMSnapshotCreateRequest.java:
##########
@@ -150,6 +155,77 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
           .addCacheEntry(new CacheKey<>(key),
             new CacheValue<>(Optional.of(snapshotInfo), transactionLogIndex));
 
+      // Create the snapshot checkpoint
+      OmSnapshotManager.createOmSnapshotCheckpoint(omMetadataManager,
+          snapshotInfo);

Review Comment:
   We had discussed this in our internal snapshot syncs. Lets not change the place where we issue the snapshot create. We have placed the checkpoint creation such that it will not cause the OM nodes to diverge from each other.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org