Re: cvs commit: jakarta-slide/src/share/org/apache/slide/authenticate CredentialsToken.java

[Christopher Lenz <cm...@gmx.de>]

26.02.2002 09:49:32, juergen@apache.org wrote:
>juergen     02/02/26 00:49:32
>
>  Modified:    src/share/org/apache/slide/authenticate
>                        CredentialsToken.java
>  Log:
>  cache principal instance and added getPrincipal method. Because I 
>  need the principal in the stores (Eckehard)

[snip]
>  +    /**
>  +     * Returns the current principal
>  +     *
>  +     * @return java.security.Principal
>  +     */
>  +    public Principal getPrinipal() {
>  +         return principal;
>  +    }

Ermmm, that should be getPrincipal() instead of getPrinipal(), I'm 
sure (focus on the missing 'c').
:o)

>       /**
>        * Returns the public creddentials.
>  -     * 
>  -     * @return String 
>  +     *
>  +     * @return String
>        */
>       public String getPublicCredentials() {
>           return credentials;

Why is it that the commits coming from you guys always report plenty 
of 'invisible' changes, like removed whitespace at end of line etc. 
It makes looking at the diffs really cumbersome. Would it be possible 
to turn that off (assuming it's being done automatically by your 
favorite editor) ?

-chris
________________________________________________________________
cmlenz at gmx.de





--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

Re: cvs commit: jakarta-slide/src/share/org/apache/slide/authenticate CredentialsToken.java

[Remy Maucherat <re...@apache.org>]

> 26.02.2002 09:49:32, juergen@apache.org wrote:
> >juergen     02/02/26 00:49:32
> >
> >  Modified:    src/share/org/apache/slide/authenticate
> >                        CredentialsToken.java
> >  Log:
> >  cache principal instance and added getPrincipal method. Because I
> >  need the principal in the stores (Eckehard)
>
> [snip]
> >  +    /**
> >  +     * Returns the current principal
> >  +     *
> >  +     * @return java.security.Principal
> >  +     */
> >  +    public Principal getPrinipal() {
> >  +         return principal;
> >  +    }
>
> Ermmm, that should be getPrincipal() instead of getPrinipal(), I'm
> sure (focus on the missing 'c').
> :o)
>
> >       /**
> >        * Returns the public creddentials.
> >  -     *
> >  -     * @return String
> >  +     *
> >  +     * @return String
> >        */
> >       public String getPublicCredentials() {
> >           return credentials;
>
> Why is it that the commits coming from you guys always report plenty
> of 'invisible' changes, like removed whitespace at end of line etc.
> It makes looking at the diffs really cumbersome. Would it be possible
> to turn that off (assuming it's being done automatically by your
> favorite editor) ?

My original sources did contain tabs. Apparently Juergen's editor converts
the tabs to spaces (hopefully, it's not the other way around ;-)), which is
good in some ways, but isn't too good an idea.

If we want to get rid of tabs, we should do it all at once, IMO. Otherwise,
it makes the diffs really annoying to deal with, as Christopher pointed out.

Remy


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>