You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "k8ika0s (via GitHub)" <gi...@apache.org> on 2026/02/13 17:17:29 UTC

[PR] [C++] Harden synthetic OOM tests for mimalloc [arrow]

k8ika0s opened a new pull request, #49281:
URL: https://github.com/apache/arrow/pull/49281

   Closes #49280
   
   ## Summary
   
   This PR makes synthetic OOM unit tests allocator-stable when mimalloc is active.
   
   It updates:
   - `cpp/src/arrow/buffer_test.cc`
   - `cpp/src/arrow/memory_pool_test.h`
   
   ## Problem
   
   These tests intentionally request extremely large allocations to force `OutOfMemory`.
   Using near-`max` bounds can hit allocator-specific fatal behavior (especially with mimalloc)
   before Arrow returns a normal OOM status, making tests environment-dependent.
   
   ## What changed
   
   1. In `ResizeOOM` and `TestOOM`, detect mimalloc backend and `GTEST_SKIP()` synthetic OOM assertions.
   2. Clamp synthetic huge allocation upper bound to `1 << 48` (256 TB), which is still impossible in practice but avoids extreme allocator boundary paths.
   3. Keep existing alignment-overflow guard (`-63`) and `ASSERT_RAISES(OutOfMemory, ...)` logic for non-mimalloc backends.
   
   ## Why this approach
   
   - Scope is intentionally minimal and test-only.
   - Preserves the goal of OOM-path coverage where behavior is reliable.
   - Removes allocator-fatal coupling from CI/unit-test expectations.
   
   ## Risk / Compatibility
   
   - No runtime library behavior change.
   - No API/ABI impact.
   - Test behavior only.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [C++] Harden synthetic OOM tests for mimalloc [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #49281:
URL: https://github.com/apache/arrow/pull/49281#issuecomment-3898350155

   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
   
   Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
   
   Then could you also rename the pull request title in the following format?
   
       GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
   
   or
   
       MINOR: [${COMPONENT}] ${SUMMARY}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/arrow/pulls/)
     * [Contribution Guidelines - Contributing Overview](https://arrow.apache.org/docs/developers/overview.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [C++] Harden synthetic OOM tests for mimalloc [arrow]

Posted by "k8ika0s (via GitHub)" <gi...@apache.org>.
k8ika0s closed pull request #49281: [C++] Harden synthetic OOM tests for mimalloc
URL: https://github.com/apache/arrow/pull/49281


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org