You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fesod.apache.org by "GGBOUNDBOY (via GitHub)" <gi...@apache.org> on 2025/10/16 11:59:45 UTC
[PR] feat: head international convert #196 [fesod]
GGBOUNDBOY opened a new pull request, #647:
URL: https://github.com/apache/fesod/pull/647
<!--
Thanks very much for contributing to Apache Fesod (Incubating)! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
Closed: #ISSUE
Related: #196
-->
## Purpose of the pull request
<!-- Describe the purpose of this pull request. For example: Closed: #ISSUE-->
## What's changed?
<!--- Describe the change below, including rationale and design decisions -->
## Checklist
- [ ] I have read the [Contributor Guide](https://fesod.apache.org/community/contribution/).
- [ ] I have written the necessary doc or comment.
- [ ] I have added the necessary unit tests and all cases have passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For additional commands, e-mail: commits-help@fesod.apache.org
Re: [PR] feat: head international convert #196 [fesod]
Posted by "GGBOUNDBOY (via GitHub)" <gi...@apache.org>.
GGBOUNDBOY closed pull request #647: feat: head international convert #196
URL: https://github.com/apache/fesod/pull/647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For additional commands, e-mail: commits-help@fesod.apache.org
Re: [PR] feat: head international convert #196 [fesod]
Posted by "delei (via GitHub)" <gi...@apache.org>.
delei commented on PR #647:
URL: https://github.com/apache/fesod/pull/647#issuecomment-3413537595
Currently, using a custom handler to modify the headers seems to also be applicable. We hope to receive more suggestions from the community to further simplify the development and facilitate expansion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For additional commands, e-mail: commits-help@fesod.apache.org
Re: [PR] feat: head international convert #196 [fesod]
Posted by "alaahong (via GitHub)" <gi...@apache.org>.
alaahong commented on PR #647:
URL: https://github.com/apache/fesod/pull/647#issuecomment-3414953189
First of all, we should pass all in CI
<img width="596" height="118" alt="image" src="https://github.com/user-attachments/assets/fa3c1484-4f4c-42c4-939d-5f5acf6c42b9" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For additional commands, e-mail: commits-help@fesod.apache.org
Re: [PR] feat: head international convert #196 [fesod]
Posted by "delei (via GitHub)" <gi...@apache.org>.
delei commented on PR #647:
URL: https://github.com/apache/fesod/pull/647#issuecomment-3410670254
Hi, @GGBOUNDBOY
Thank you for submitting this PR.
FYI, we do need to support internationalization. I feel the current implementation proposal seems overly simplified. We need to discuss solutions in issue #57 , such as supporting `Locale` and `MessageSource`.
Without further improvements or optimized implementation solutions, it is recommended not to merge this PR yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For additional commands, e-mail: commits-help@fesod.apache.org
Re: [PR] feat: head international convert #196 [fesod]
Posted by "GGBOUNDBOY (via GitHub)" <gi...@apache.org>.
GGBOUNDBOY commented on PR #647:
URL: https://github.com/apache/fesod/pull/647#issuecomment-3413440293
> Hi, @GGBOUNDBOY
>
> Thank you for submitting this PR.
>
> FYI, we do need to support internationalization. I feel the current implementation proposal seems overly simplified. We need to discuss solutions in issue #57 , such as supporting `Locale` and `MessageSource`.
>
> Without further improvements or optimized implementation solutions, it is recommended not to merge this PR yet.
使用函数控制表头转换比使用多语言的方式是不是更加容易扩展，因为无法确认使用者最终是使用那种方式来实现多语言的，可能使用者有自己的一套实现的方式，并不是基于spring boot的。使用者只要实现相应的方法，按项目的实际情况来扩展表头转换即可。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For additional commands, e-mail: commits-help@fesod.apache.org