You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2018/02/19 06:31:00 UTC
Review Request 65707: Enabled docker containerizer in Mesos mini
container.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65707/
-----------------------------------------------------------
Review request for mesos and Benjamin Bannier.
Repository: mesos
Description
-------
Enabled docker containerizer in Mesos mini container.
Diffs
-----
support/mesos-mini/mesos_agent_environment 8390f15e8d300e8076da92e7a157021bcfab74dc
Diff: https://reviews.apache.org/r/65707/diff/1/
Testing
-------
Tested locally.
Thanks,
Jie Yu
Re: Review Request 65707: Enabled docker containerizer in Mesos mini
container.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65707/#review197741
-----------------------------------------------------------
PASS: Mesos patch 65707 was successfully built and tested.
Reviews applied: `['65706', '65707']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65707
- Mesos Reviewbot Windows
On Feb. 19, 2018, 6:31 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65707/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2018, 6:31 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enabled docker containerizer in Mesos mini container.
>
>
> Diffs
> -----
>
> support/mesos-mini/mesos_agent_environment 8390f15e8d300e8076da92e7a157021bcfab74dc
>
>
> Diff: https://reviews.apache.org/r/65707/diff/1/
>
>
> Testing
> -------
>
> Tested locally.
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 65707: Enabled docker containerizer in Mesos mini
container.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65707/#review197743
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65706, 65707]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 19, 2018, 6:31 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65707/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2018, 6:31 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enabled docker containerizer in Mesos mini container.
>
>
> Diffs
> -----
>
> support/mesos-mini/mesos_agent_environment 8390f15e8d300e8076da92e7a157021bcfab74dc
>
>
> Diff: https://reviews.apache.org/r/65707/diff/1/
>
>
> Testing
> -------
>
> Tested locally.
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 65707: Enabled docker containerizer in Mesos mini
container.
Posted by Jie Yu <yu...@gmail.com>.
> On Feb. 19, 2018, 3:14 p.m., Benjamin Bannier wrote:
> > support/mesos-mini/mesos_agent_environment
> > Lines 5 (patched)
> > <https://reviews.apache.org/r/65707/diff/1/?file=1962589#file1962589line5>
> >
> > Might as well put these in alphabetic order.
I want Mesos containerizer to be queried first.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65707/#review197756
-----------------------------------------------------------
On Feb. 19, 2018, 6:31 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65707/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2018, 6:31 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enabled docker containerizer in Mesos mini container.
>
>
> Diffs
> -----
>
> support/mesos-mini/mesos_agent_environment 8390f15e8d300e8076da92e7a157021bcfab74dc
>
>
> Diff: https://reviews.apache.org/r/65707/diff/1/
>
>
> Testing
> -------
>
> Tested locally.
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 65707: Enabled docker containerizer in Mesos mini
container.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65707/#review197756
-----------------------------------------------------------
Fix it, then Ship it!
support/mesos-mini/mesos_agent_environment
Lines 5 (patched)
<https://reviews.apache.org/r/65707/#comment278039>
Might as well put these in alphabetic order.
- Benjamin Bannier
On Feb. 19, 2018, 7:31 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65707/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2018, 7:31 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enabled docker containerizer in Mesos mini container.
>
>
> Diffs
> -----
>
> support/mesos-mini/mesos_agent_environment 8390f15e8d300e8076da92e7a157021bcfab74dc
>
>
> Diff: https://reviews.apache.org/r/65707/diff/1/
>
>
> Testing
> -------
>
> Tested locally.
>
>
> Thanks,
>
> Jie Yu
>
>