You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Anshul Gangwar <an...@citrix.com> on 2013/09/16 12:19:35 UTC
Review Request 14147: marvin tests for Persistent networks without running a
VM
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14147/
-----------------------------------------------------------
Review request for cloudstack, Likitha Shetty, sailaja mada, and Prasanna Santhanam.
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-2232
Repository: cloudstack-git
Description
-------
marvin tests for Persistent networks without running a VM
Diffs
-----
test/integration/component/test_persistent_networks.py PRE-CREATION
tools/marvin/marvin/integration/lib/base.py 9e46065
Diff: https://reviews.apache.org/r/14147/diff/
Testing
-------
ran successfully on my local advanced zone setup
Thanks,
Anshul Gangwar
Re: Review Request 14147: marvin tests for Persistent networks without
running a VM
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14147/#review27014
-----------------------------------------------------------
Likitha, could you help me on this review? I'm not too familiar with the user scenarios of this feature.
- Prasanna Santhanam
On Sept. 16, 2013, 11:26 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14147/
> -----------------------------------------------------------
>
> (Updated Sept. 16, 2013, 11:26 a.m.)
>
>
> Review request for cloudstack, Likitha Shetty, sailaja mada, and Prasanna Santhanam.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-2232
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> marvin tests for Persistent networks without running a VM
>
>
> Diffs
> -----
>
> test/integration/component/test_persistent_networks.py PRE-CREATION
> tools/marvin/marvin/integration/lib/base.py 9e46065
>
> Diff: https://reviews.apache.org/r/14147/diff/
>
>
> Testing
> -------
>
> ran successfully on my local advanced zone setup
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request 14147: marvin tests for Persistent networks without
running a VM
Posted by Likitha Shetty <li...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14147/#review27179
-----------------------------------------------------------
Ship it!
Ship It!
- Likitha Shetty
On Oct. 18, 2013, 8:21 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14147/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2013, 8:21 a.m.)
>
>
> Review request for cloudstack, Likitha Shetty, sailaja mada, and Prasanna Santhanam.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-2232
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-2232
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> marvin tests for Persistent networks without running a VM
>
>
> Diffs
> -----
>
> test/integration/component/test_persistent_networks.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14147/diff/
>
>
> Testing
> -------
>
> ran successfully on my local advanced zone setup
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request 14147: marvin tests for Persistent networks without
running a VM
Posted by Anshul Gangwar <an...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14147/
-----------------------------------------------------------
(Updated Oct. 18, 2013, 8:21 a.m.)
Review request for cloudstack, Likitha Shetty, sailaja mada, and Prasanna Santhanam.
Changes
-------
removed the base.py file changes
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-2232
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-2232
Repository: cloudstack-git
Description
-------
marvin tests for Persistent networks without running a VM
Diffs (updated)
-----
test/integration/component/test_persistent_networks.py PRE-CREATION
Diff: https://reviews.apache.org/r/14147/diff/
Testing
-------
ran successfully on my local advanced zone setup
Thanks,
Anshul Gangwar
Re: Review Request 14147: marvin tests for Persistent networks without
running a VM
Posted by Likitha Shetty <li...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14147/#review27177
-----------------------------------------------------------
Please update the diff to remove the change made to base.py as it has already been checked in.
Otherwise it looks good to me. Good test case coverage.
- Likitha Shetty
On Sept. 16, 2013, 11:26 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14147/
> -----------------------------------------------------------
>
> (Updated Sept. 16, 2013, 11:26 a.m.)
>
>
> Review request for cloudstack, Likitha Shetty, sailaja mada, and Prasanna Santhanam.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-2232
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-2232
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> marvin tests for Persistent networks without running a VM
>
>
> Diffs
> -----
>
> test/integration/component/test_persistent_networks.py PRE-CREATION
> tools/marvin/marvin/integration/lib/base.py 9e46065
>
> Diff: https://reviews.apache.org/r/14147/diff/
>
>
> Testing
> -------
>
> ran successfully on my local advanced zone setup
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request 14147: marvin tests for Persistent networks without
running a VM
Posted by Anshul Gangwar <an...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14147/
-----------------------------------------------------------
(Updated Sept. 16, 2013, 11:26 a.m.)
Review request for cloudstack, Likitha Shetty, sailaja mada, and Prasanna Santhanam.
Changes
-------
tagged the tests for adavnced zone and removed extraneous parameters from virtual_machine json
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-2232
Repository: cloudstack-git
Description
-------
marvin tests for Persistent networks without running a VM
Diffs (updated)
-----
test/integration/component/test_persistent_networks.py PRE-CREATION
tools/marvin/marvin/integration/lib/base.py 9e46065
Diff: https://reviews.apache.org/r/14147/diff/
Testing
-------
ran successfully on my local advanced zone setup
Thanks,
Anshul Gangwar