You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Matthew de Detrich <ma...@aiven.io.INVALID> on 2021/06/08 10:28:45 UTC

[DISCUSS] KIP--754: Make Scala case class's final

Hello everyone,

I'd like to discuss the following KIP which involves making all scala case
class's final due to best practices
https://cwiki.apache.org/confluence/display/KAFKA/KIP-754%3A+Make+Scala+case+class%27s+final

Doing this for the upcoming Kafka 3.0.0 release would be ideal due to
source breaking change.

-- 

Matthew de Detrich

*Aiven Deutschland GmbH*

Immanuelkirchstraße 26, 10405 Berlin

Amtsgericht Charlottenburg, HRB 209739 B

Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen

*m:* +491603708037

*w:* aiven.io *e:* matthew.dedetrich@aiven.io

Re: [DISCUSS] KIP--754: Make Scala case class's final

Posted by Matthew de Detrich <ma...@aiven.io.INVALID>.
Pull request has been made at https://github.com/apache/kafka/pull/10839

On Tue, Jun 8, 2021 at 12:28 PM Matthew de Detrich <
matthew.dedetrich@aiven.io> wrote:

> Hello everyone,
>
> I'd like to discuss the following KIP which involves making all scala case
> class's final due to best practices
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-754%3A+Make+Scala+case+class%27s+final
>
> Doing this for the upcoming Kafka 3.0.0 release would be ideal due to
> source breaking change.
>
> --
>
> Matthew de Detrich
>
> *Aiven Deutschland GmbH*
>
> Immanuelkirchstraße 26, 10405 Berlin
>
> Amtsgericht Charlottenburg, HRB 209739 B
>
> Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen
>
> *m:* +491603708037
>
> *w:* aiven.io *e:* matthew.dedetrich@aiven.io
>


-- 

Matthew de Detrich

*Aiven Deutschland GmbH*

Immanuelkirchstraße 26, 10405 Berlin

Amtsgericht Charlottenburg, HRB 209739 B

Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen

*m:* +491603708037

*w:* aiven.io *e:* matthew.dedetrich@aiven.io

Re: [DISCUSS] KIP--754: Make Scala case class's final

Posted by Matthew de Detrich <ma...@aiven.io.INVALID>.
So I am only changing Scala code within the core project, if there are no
public interfaces within that project then yes I think you are right.

On Tue, 8 Jun 2021, 16:07 Ismael Juma, <is...@juma.me.uk> wrote:

> Hi,
>
> Thanks for the KIP. KIPs are meant to focus on public facing APIs,
> protocols, configs, etc. The only Scala API that is public facing is the
> Kafka Streams Scala API. Is this KIP focused on that?
>
> Ismael
>
> On Tue, Jun 8, 2021 at 3:29 AM Matthew de Detrich
> <ma...@aiven.io.invalid> wrote:
>
> > Hello everyone,
> >
> > I'd like to discuss the following KIP which involves making all scala
> case
> > class's final due to best practices
> >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-754%3A+Make+Scala+case+class%27s+final
> >
> > Doing this for the upcoming Kafka 3.0.0 release would be ideal due to
> > source breaking change.
> >
> > --
> >
> > Matthew de Detrich
> >
> > *Aiven Deutschland GmbH*
> >
> > Immanuelkirchstraße 26, 10405 Berlin
> >
> > Amtsgericht Charlottenburg, HRB 209739 B
> >
> > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen
> >
> > *m:* +491603708037
> >
> > *w:* aiven.io *e:* matthew.dedetrich@aiven.io
> >
>

Re: [DISCUSS] KIP--754: Make Scala case class's final

Posted by Ismael Juma <is...@juma.me.uk>.
Hi,

Thanks for the KIP. KIPs are meant to focus on public facing APIs,
protocols, configs, etc. The only Scala API that is public facing is the
Kafka Streams Scala API. Is this KIP focused on that?

Ismael

On Tue, Jun 8, 2021 at 3:29 AM Matthew de Detrich
<ma...@aiven.io.invalid> wrote:

> Hello everyone,
>
> I'd like to discuss the following KIP which involves making all scala case
> class's final due to best practices
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-754%3A+Make+Scala+case+class%27s+final
>
> Doing this for the upcoming Kafka 3.0.0 release would be ideal due to
> source breaking change.
>
> --
>
> Matthew de Detrich
>
> *Aiven Deutschland GmbH*
>
> Immanuelkirchstraße 26, 10405 Berlin
>
> Amtsgericht Charlottenburg, HRB 209739 B
>
> Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen
>
> *m:* +491603708037
>
> *w:* aiven.io *e:* matthew.dedetrich@aiven.io
>