You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Bikas Saha (JIRA)" <ji...@apache.org> on 2012/08/07 01:28:03 UTC
[jira] [Created] (HADOOP-8657) TestCLI fails on Windows because it
uses hardcoded file length of test files committed to the source code
Bikas Saha created HADOOP-8657:
----------------------------------
Summary: TestCLI fails on Windows because it uses hardcoded file length of test files committed to the source code
Key: HADOOP-8657
URL: https://issues.apache.org/jira/browse/HADOOP-8657
Project: Hadoop Common
Issue Type: Bug
Reporter: Bikas Saha
Assignee: Bikas Saha
The actual length of the file would depend on the character encoding used and hence cannot be hard-coded.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8657) TestCLI fails on Windows because
it uses hardcoded file length of test files committed to the source code
Posted by "Bikas Saha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442823#comment-13442823 ]
Bikas Saha commented on HADOOP-8657:
------------------------------------
The test was failing because it was checking for file sizes on disk and the sizes were hardcoded in the test. text file sizes can be different on different platforms based on character encodings etc. The fix was to read the actual file size from disk and then check values based on that instead of some hardcoded value. The test files are actually checked into the source as resources. Ideally, the test would generate these files on the fly instead of checking them in but I am leaving that re-organization of the code tree for later when the branch is merged back so as to simplify the merge.
> TestCLI fails on Windows because it uses hardcoded file length of test files committed to the source code
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8657
> URL: https://issues.apache.org/jira/browse/HADOOP-8657
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: HADOOP-8657.branch-1-win.1.patch
>
>
> The actual length of the file would depend on the character encoding used and hence cannot be hard-coded.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8657) TestCLI fails on Windows because it
uses hardcoded file length of test files committed to the source code
Posted by "Bikas Saha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bikas Saha updated HADOOP-8657:
-------------------------------
Attachment: HADOOP-8657.branch-1-win.1.patch
> TestCLI fails on Windows because it uses hardcoded file length of test files committed to the source code
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8657
> URL: https://issues.apache.org/jira/browse/HADOOP-8657
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: HADOOP-8657.branch-1-win.1.patch
>
>
> The actual length of the file would depend on the character encoding used and hence cannot be hard-coded.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8657) TestCLI fails on Windows because it
uses hardcoded file length of test files committed to the source code
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy updated HADOOP-8657:
----------------------------------
Resolution: Fixed
Fix Version/s: 1-win
Status: Resolved (was: Patch Available)
I just committed this. Thanks Bikas!
> TestCLI fails on Windows because it uses hardcoded file length of test files committed to the source code
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8657
> URL: https://issues.apache.org/jira/browse/HADOOP-8657
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Fix For: 1-win
>
> Attachments: HADOOP-8657.branch-1-win.1.patch
>
>
> The actual length of the file would depend on the character encoding used and hence cannot be hard-coded.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8657) TestCLI fails on Windows because it
uses hardcoded file length of test files committed to the source code
Posted by "Bikas Saha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bikas Saha updated HADOOP-8657:
-------------------------------
Status: Patch Available (was: Open)
> TestCLI fails on Windows because it uses hardcoded file length of test files committed to the source code
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8657
> URL: https://issues.apache.org/jira/browse/HADOOP-8657
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: HADOOP-8657.branch-1-win.1.patch
>
>
> The actual length of the file would depend on the character encoding used and hence cannot be hard-coded.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8657) TestCLI fails on Windows because
it uses hardcoded file length of test files committed to the source code
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442867#comment-13442867 ]
Hadoop QA commented on HADOOP-8657:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12542699/HADOOP-8657.branch-1-win.1.patch
against trunk revision .
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1372//console
This message is automatically generated.
> TestCLI fails on Windows because it uses hardcoded file length of test files committed to the source code
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8657
> URL: https://issues.apache.org/jira/browse/HADOOP-8657
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: HADOOP-8657.branch-1-win.1.patch
>
>
> The actual length of the file would depend on the character encoding used and hence cannot be hard-coded.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira