You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Laszlo Hornyak <la...@gmail.com> on 2013/10/11 21:14:39 UTC
Review Request 14605: Fill the creationMonitors based on priority
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14605/
-----------------------------------------------------------
Review request for cloudstack and Darren Shepherd.
Repository: cloudstack-git
Description
-------
If not priotity, append to the end of the list.
Diffs
-----
engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java 4202015
Diff: https://reviews.apache.org/r/14605/diff/
Testing
-------
not really, just guessing this is how it was meant (please review)
Thanks,
Laszlo Hornyak
Re: Review Request 14605: Fill the creationMonitors based on priority
Posted by Darren Shepherd <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14605/#review28546
-----------------------------------------------------------
Ship it!
Laszlo can you commit this?
- Darren Shepherd
On Oct. 11, 2013, 7:14 p.m., Laszlo Hornyak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14605/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2013, 7:14 p.m.)
>
>
> Review request for cloudstack and Darren Shepherd.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> If not priotity, append to the end of the list.
>
>
> Diffs
> -----
>
> engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java 4202015
>
> Diff: https://reviews.apache.org/r/14605/diff/
>
>
> Testing
> -------
>
> not really, just guessing this is how it was meant (please review)
>
>
> Thanks,
>
> Laszlo Hornyak
>
>
Re: Review Request 14605: Fill the creationMonitors based on priority
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14605/#review26966
-----------------------------------------------------------
Ship it!
Ship It!
- daan Hoogland
On Oct. 11, 2013, 7:14 p.m., Laszlo Hornyak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14605/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2013, 7:14 p.m.)
>
>
> Review request for cloudstack and Darren Shepherd.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> If not priotity, append to the end of the list.
>
>
> Diffs
> -----
>
> engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java 4202015
>
> Diff: https://reviews.apache.org/r/14605/diff/
>
>
> Testing
> -------
>
> not really, just guessing this is how it was meant (please review)
>
>
> Thanks,
>
> Laszlo Hornyak
>
>