[GitHub] KellenSunderland commented on a change in pull request #11492: Move Apache RAT installation into Docker layers

[GitBox <gi...@apache.org>]

KellenSunderland commented on a change in pull request #11492: Move Apache RAT installation into Docker layers
URL: https://github.com/apache/incubator-mxnet/pull/11492#discussion_r199153952
 
 

 ##########
 File path: ci/docker/install/ubuntu_rat.sh
 ##########
 @@ -30,22 +33,4 @@ echo "mvn install"
 mvn -Dmaven.test.skip=true install #>/dev/null
 
 echo "build success, cd into target"
-cd apache-rat/target
-
-
-echo "-------Run Apache RAT check on MXNet-------"
-
-#Command has been run twice, once for the logs and once to store in the variable to parse.
-java -jar apache-rat-0.13-SNAPSHOT.jar -E /work/mxnet/tests/nightly/apache_rat_license_check/rat-excludes -d /work/mxnet
-OUTPUT="$(java -jar apache-rat-0.13-SNAPSHOT.jar -E /work/mxnet/tests/nightly/apache_rat_license_check/rat-excludes -d /work/mxnet)"
-SOURCE="^0 Unknown Licenses"
-
-
-echo "-------Process The Output-------"
-
-if [[ "$OUTPUT" =~ $SOURCE ]]; then
-      echo "SUCCESS: There are no files with an Unknown License.";
-else
-      echo "ERROR: RAT Check detected files with unknown licenses. Please fix and run test again!";
-      exit 1
-fi
\ No newline at end of file
+cd apache-rat/target
 
 Review comment:
   And why do we cd at the end of an installation shell script?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services