[GitHub] [incubator-doris] yangzhg commented on a change in pull request #4770: Fix delete_sign predicate assing to join node

[GitBox <gi...@apache.org>]

yangzhg commented on a change in pull request #4770:
URL: https://github.com/apache/incubator-doris/pull/4770#discussion_r508946382



##########
File path: fe/fe-core/src/main/java/org/apache/doris/planner/OlapScanNode.java
##########
@@ -278,6 +280,15 @@ protected String debugString() {
     @Override
     public void init(Analyzer analyzer) throws UserException {
         super.init(analyzer);
+        if (!Util.showHiddenColumns() && olapTable.hasDeleteSign()) {

Review comment:
       olaptable may also has other hidden columns. It is not appropriate to add such a function to each hidden column, and the writing method is not particularly complicated.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org