You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/22 15:22:24 UTC

[GitHub] [arrow-rs] tustvold commented on pull request #1722: Fix BitReader::get_batch zero extension (#1708)

tustvold commented on PR #1722:
URL: https://github.com/apache/arrow-rs/pull/1722#issuecomment-1133919286

   Unfortunately this does represent a performance regression, but better slow and correct, than fast and incorrect. I'll have a think about how we might reduce this
   
   ```
   arrow_array_reader/Int64Array/binary packed, mandatory, no NULLs                                                                             
                           time:   [57.063 us 57.083 us 57.103 us]
                           change: [+96.098% +96.190% +96.272%] (p = 0.00 < 0.05)
                           Performance has regressed.
   Found 2 outliers among 100 measurements (2.00%)
     2 (2.00%) high mild
   arrow_array_reader/Int64Array/binary packed, optional, no NULLs                                                                            
                           time:   [69.239 us 69.262 us 69.285 us]
                           change: [+75.438% +75.559% +75.670%] (p = 0.00 < 0.05)
                           Performance has regressed.
   Found 1 outliers among 100 measurements (1.00%)
     1 (1.00%) high mild
   arrow_array_reader/Int64Array/binary packed, optional, half NULLs                                                                             
                           time:   [49.888 us 49.967 us 50.119 us]
                           change: [+32.282% +32.712% +33.038%] (p = 0.00 < 0.05)
                           Performance has regressed.
   Found 5 outliers among 100 measurements (5.00%)
     3 (3.00%) high mild
     2 (2.00%) high severe
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org