You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/08 10:22:39 UTC
[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #10016: [enhancement]Cache parsed page data for bitshuffle encoding
yiguolei commented on code in PR #10016:
URL: https://github.com/apache/incubator-doris/pull/10016#discussion_r892186809
##########
be/src/olap/rowset/segment_v2/binary_dict_page.cpp:
##########
@@ -313,5 +315,23 @@ Status BinaryDictPageDecoder::next_batch(size_t* n, ColumnBlockView* dst) {
return Status::OK();
}
+BinaryDictPageDecoder* BinaryDictPageDecoder::clone_for_cache() const {
Review Comment:
doris's code style is Status BinaryDictPageDecoder::clone_for_cache(std::unique_ptr< BinaryDictPageDecoder >& BinaryDictPageDecoder)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org