You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jason Huynh <hu...@gmail.com> on 2015/11/23 19:59:05 UTC
Review Request 40605: GEODE-585: Simplify hash index code
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40605/
-----------------------------------------------------------
Review request for geode, Anthony Baker, anilkumar gingade, and Bruce Schuchardt.
Bugs: GEODE-585
https://issues.apache.org/jira/browse/GEODE-585
Repository: geode
Description
-------
Refactored hash index and hash index set
Using modified versions of the fastutil methods for adding and finding index positions for objects
Added hash index set unit tests
Removes PrimeFinder, ObjectProcedure, and HashIndexStrategy
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/HashIndex.java dd9cffd
gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/HashIndexSet.java 85887d4
gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/HashIndexStrategy.java 3ed0caf
gemfire-core/src/main/java/com/gemstone/gemfire/internal/util/ObjectProcedure.java 421b6c8
gemfire-core/src/main/java/com/gemstone/gemfire/internal/util/PrimeFinder.java 529e5a2
gemfire-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/HashIndexJUnitTest.java e3247a7
gemfire-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/HashIndexSetJUnitTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/40605/diff/
Testing
-------
precheckin
Thanks,
Jason Huynh
Re: Review Request 40605: GEODE-585: Simplify hash index code
Posted by anilkumar gingade <ag...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40605/#review107658
-----------------------------------------------------------
gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/HashIndex.java (line 716)
<https://reviews.apache.org/r/40605/#comment166887>
Lets move this within orderby context.
- anilkumar gingade
On Nov. 23, 2015, 6:59 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40605/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2015, 6:59 p.m.)
>
>
> Review request for geode, Anthony Baker, anilkumar gingade, and Bruce Schuchardt.
>
>
> Bugs: GEODE-585
> https://issues.apache.org/jira/browse/GEODE-585
>
>
> Repository: geode
>
>
> Description
> -------
>
> Refactored hash index and hash index set
> Using modified versions of the fastutil methods for adding and finding index positions for objects
> Added hash index set unit tests
> Removes PrimeFinder, ObjectProcedure, and HashIndexStrategy
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/HashIndex.java dd9cffd
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/HashIndexSet.java 85887d4
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/HashIndexStrategy.java 3ed0caf
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/util/ObjectProcedure.java 421b6c8
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/util/PrimeFinder.java 529e5a2
> gemfire-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/HashIndexJUnitTest.java e3247a7
> gemfire-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/HashIndexSetJUnitTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/40605/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Jason Huynh
>
>
Re: Review Request 40605: GEODE-585: Simplify hash index code
Posted by anilkumar gingade <ag...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40605/#review107669
-----------------------------------------------------------
Ship it!
Ship It!
- anilkumar gingade
On Nov. 23, 2015, 6:59 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40605/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2015, 6:59 p.m.)
>
>
> Review request for geode, Anthony Baker, anilkumar gingade, and Bruce Schuchardt.
>
>
> Bugs: GEODE-585
> https://issues.apache.org/jira/browse/GEODE-585
>
>
> Repository: geode
>
>
> Description
> -------
>
> Refactored hash index and hash index set
> Using modified versions of the fastutil methods for adding and finding index positions for objects
> Added hash index set unit tests
> Removes PrimeFinder, ObjectProcedure, and HashIndexStrategy
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/HashIndex.java dd9cffd
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/HashIndexSet.java 85887d4
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/HashIndexStrategy.java 3ed0caf
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/util/ObjectProcedure.java 421b6c8
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/util/PrimeFinder.java 529e5a2
> gemfire-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/HashIndexJUnitTest.java e3247a7
> gemfire-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/HashIndexSetJUnitTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/40605/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Jason Huynh
>
>