[GitHub] [phoenix-queryserver] luocooong opened a new pull request #58: PHOENIX-6398: Returns uniform SQL dialect in calcite for the PQS

[GitBox <gi...@apache.org>]

luocooong opened a new pull request #58:
URL: https://github.com/apache/phoenix-queryserver/pull/58


   # [PHOENIX-6398](https://issues.apache.org/jira/browse/PHOENIX-6398): Returns uniform SQL dialect in calcite for the PQS
   
   ## Description
   
   database name in core module
   ```java
   @Override
   public String getDatabaseProductName() throws SQLException {
       return "Phoenix";
   }
   ```
   
   database name in PQS module
   ```java
   return DriverVersion.load(
       Driver.class,
       "org-apache-phoenix-remote-jdbc.properties",
       "Phoenix Remote JDBC Driver",
       "unknown version",
       "Apache Phoenix",
       "unknown version");
   ```
   
   In result, Calcite could not create `PhoenixSqlDialect` for PQS. (org.apache.calcite.sql.SqlDialectFactoryImpl)
   ```java
   case "ORACLE":
     return new OracleSqlDialect(c);
   case "PHOENIX":
     return new PhoenixSqlDialect(c);
   .....
   ```
   
   ## Documentation
     There are no changes visible to the user.
   
   ## Testing
     1. Builded the `phoenix-queryserver-client-[XXX]-SNAPSHOT.jar`
     2. Returns uniform SQL dialect `org.apache.calcite.sql.dialect.PhoenixSqlDialect@1e0b4072`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [phoenix-queryserver] stoty closed pull request #58: PHOENIX-6398: Returns uniform SQL dialect in calcite for the PQS

[GitBox <gi...@apache.org>]

stoty closed pull request #58:
URL: https://github.com/apache/phoenix-queryserver/pull/58


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org