You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@plc4x.apache.org by GitBox <gi...@apache.org> on 2019/03/06 08:08:03 UTC

[GitHub] [incubator-plc4x] JulianFeinauer commented on issue #46: PLC4X-88: Add Triggering to PLC Scraper

JulianFeinauer commented on issue #46: PLC4X-88: Add Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#issuecomment-470009105
 
 
   Hey @timbo2k I'm pretty impressed by your work (especially I like the syntax we now have for the triggering modes).
   I added a lot of small points which are mostly no-brainers to fix.
   If we add some more tests I think we are ready to merge ASAP!.
   
   Very well done 👍 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services