[GitHub] [spark] MaxGekk commented on a change in pull request #32099: [SPARK-34905][SQL][TESTS] Enable ANSI intervals in `SQLQueryTestSuite`/`ThriftServerQueryTestSuite`

[GitBox <gi...@apache.org>]

MaxGekk commented on a change in pull request #32099:
URL: https://github.com/apache/spark/pull/32099#discussion_r611444643



##########
File path: sql/core/src/test/resources/sql-tests/results/ansi/datetime.sql.out
##########
@@ -359,31 +359,31 @@ cannot resolve '1 + (- INTERVAL '2 seconds')' due to data type mismatch: argumen
 -- !query
 select date'2020-01-01' - timestamp'2019-10-06 10:11:12.345678'
 -- !query schema
-struct<subtracttimestamps(DATE '2020-01-01', TIMESTAMP '2019-10-06 10:11:12.345678'):interval>
+struct<subtracttimestamps(DATE '2020-01-01', TIMESTAMP '2019-10-06 10:11:12.345678'):day-time interval>

Review comment:
       Not yet. So far, I took the names for the sub-types from the SQL standard, see https://github.com/apache/spark/pull/31810
   
   Probably, we will need to re-define them when we will implement parsing of interval types from SQL.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org