[jira] [Commented] (KAFKA-2247) Merge kafka.utils.Time and kafka.common.utils.Time

["Gwen Shapira (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14573803#comment-14573803 ] 

Gwen Shapira commented on KAFKA-2247:
-------------------------------------

It seems fairly easy except that kafka.utils.Time has milliseconds() exposed as static, while kafka.common.utils.Time is just an interface and therefore can't do that.
To avoid having our code instantiate new objects every time we need to check the time (see what I did there?), I suggest turning o.a.k.common.utils.Time into an abstract class and add some static methods there.

Does that make sense?

> Merge kafka.utils.Time and kafka.common.utils.Time
> --------------------------------------------------
>
>                 Key: KAFKA-2247
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2247
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Aditya Auradkar
>            Assignee: Aditya Auradkar
>            Priority: Minor
>
> We currently have 2 different versions of Time in clients and core. These need to be merged



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)