You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@age.apache.org by "panosfol (via GitHub)" <gi...@apache.org> on 2023/07/15 01:29:16 UTC
[GitHub] [age] panosfol opened a new pull request, #1040: Fixed case sensitivity on label usage of reserved keyword
panosfol opened a new pull request, #1040:
URL: https://github.com/apache/age/pull/1040
This resolves #1028.
@rafsun42 Awaiting review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] panosfol commented on pull request #1040: Fixed case sensitivity on label usage of reserved keyword
Posted by "panosfol (via GitHub)" <gi...@apache.org>.
panosfol commented on PR #1040:
URL: https://github.com/apache/age/pull/1040#issuecomment-1641262376
@rafsun42 done with adding regression tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] panosfol commented on pull request #1040: Fixed case sensitivity on label usage of reserved keyword
Posted by "panosfol (via GitHub)" <gi...@apache.org>.
panosfol commented on PR #1040:
URL: https://github.com/apache/age/pull/1040#issuecomment-1642768741
> @panosfol Did you check the other two comments I made above yesterday?
About adding regression tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] panosfol commented on pull request #1040: Fixed case sensitivity on label usage of reserved keyword
Posted by "panosfol (via GitHub)" <gi...@apache.org>.
panosfol commented on PR #1040:
URL: https://github.com/apache/age/pull/1040#issuecomment-1639030229
Yes of course! Want me to add them to here or open a new PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] panosfol commented on pull request #1040: Fixed case sensitivity on label usage of reserved keyword
Posted by "panosfol (via GitHub)" <gi...@apache.org>.
panosfol commented on PR #1040:
URL: https://github.com/apache/age/pull/1040#issuecomment-1639032896
OK im on it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] rafsun42 commented on pull request #1040: Fixed case sensitivity on label usage of reserved keyword
Posted by "rafsun42 (via GitHub)" <gi...@apache.org>.
rafsun42 commented on PR #1040:
URL: https://github.com/apache/age/pull/1040#issuecomment-1642767626
@panosfol Did you check the other two comments I made above yesterday?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] rafsun42 commented on pull request #1040: Fixed case sensitivity on label usage of reserved keyword
Posted by "rafsun42 (via GitHub)" <gi...@apache.org>.
rafsun42 commented on PR #1040:
URL: https://github.com/apache/age/pull/1040#issuecomment-1639029417
@panosfol Could you please add regression tests for any issues that were fixed by this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] rafsun42 commented on pull request #1040: Fixed case sensitivity on label usage of reserved keyword
Posted by "rafsun42 (via GitHub)" <gi...@apache.org>.
rafsun42 commented on PR #1040:
URL: https://github.com/apache/age/pull/1040#issuecomment-1644794210
@panosfol Good. Send a PR to PG11 and PG12.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] panosfol commented on pull request #1040: Fixed case sensitivity on label usage of reserved keyword
Posted by "panosfol (via GitHub)" <gi...@apache.org>.
panosfol commented on PR #1040:
URL: https://github.com/apache/age/pull/1040#issuecomment-1644551008
@rafsun42 I looked into the `pstrdup()` function and its something that postgres uses for every string assignment to avoid memory leaks. Also I added `truncate_identifier()` to shave off any whitespaces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] jrgemignani commented on pull request #1040: Fixed case sensitivity on label usage of reserved keyword
Posted by "jrgemignani (via GitHub)" <gi...@apache.org>.
jrgemignani commented on PR #1040:
URL: https://github.com/apache/age/pull/1040#issuecomment-1642561031
@panosfol FYI: Any addition (feature, modification, bug fix) to AGE is required to have regression tests. The only exceptions are where none are possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] panosfol commented on pull request #1040: Fixed case sensitivity on label usage of reserved keyword
Posted by "panosfol (via GitHub)" <gi...@apache.org>.
panosfol commented on PR #1040:
URL: https://github.com/apache/age/pull/1040#issuecomment-1642565348
> @panosfol FYI: Any addition (feature, modification, bug fix) to AGE is required to have regression tests. The only exceptions are where none are possible.
Noted!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] panosfol commented on pull request #1040: Fixed case sensitivity on label usage of reserved keyword
Posted by "panosfol (via GitHub)" <gi...@apache.org>.
panosfol commented on PR #1040:
URL: https://github.com/apache/age/pull/1040#issuecomment-1636612303
@rafsun42 Awaiting for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] rafsun42 commented on pull request #1040: Fixed case sensitivity on label usage of reserved keyword
Posted by "rafsun42 (via GitHub)" <gi...@apache.org>.
rafsun42 commented on PR #1040:
URL: https://github.com/apache/age/pull/1040#issuecomment-1639032357
@panosfol
> Yes of course! Want me to add them to here or open a new PR?
You can add them here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] rafsun42 merged pull request #1040: Fixed case sensitivity on label usage of reserved keyword
Posted by "rafsun42 (via GitHub)" <gi...@apache.org>.
rafsun42 merged PR #1040:
URL: https://github.com/apache/age/pull/1040
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org