You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by fhueske <gi...@git.apache.org> on 2015/04/27 10:34:09 UTC
[GitHub] flink pull request: [FLINK-1682] Ported optimizer unit tests from ...
GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/627
[FLINK-1682] Ported optimizer unit tests from Record API to Java API
This is a step towards removing the deprecated Record API.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fhueske/flink recordOptimizerTests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/627.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #627
----
commit 303e86cc7af2604c3d9c781bd08a656daf6b99ae
Author: Fabian Hueske <fh...@apache.org>
Date: 2015-04-24T23:30:11Z
[FLINK-1682] Ported optimizer unit tests from Record API to Java API
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1682] Ported optimizer unit tests from ...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/627#issuecomment-98781884
Any objections against merging this PR?
Otherwise, I'll do that tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1682] Ported optimizer unit tests from ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/627
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1682] Ported optimizer unit tests from ...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/627#issuecomment-96631688
Yes, very good point.
I replaced the `.print()` statements by `.output(new DiscardingOutputFormat()` as suggested (not only in the ported tests but also some more on the way).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1682] Ported optimizer unit tests from ...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/627#issuecomment-96580250
Wow, very nice :-) Looks correct from a first glance (I did not thoroughly check everything).
One remark: Since `print()` may become an eagerly evaluated command in the future, the tests become more robust when using `.output(new DiscardingOutputFormat())` as the sink.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---