You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/18 12:58:33 UTC

[GitHub] [flink] godfreyhe opened a new pull request #14429: [FLINK-20623][table-planner-blink] Introduce StreamPhysicalWatermarkAssigner, and make StreamExecWatermarkAssigner only extended from ExecNode

godfreyhe opened a new pull request #14429:
URL: https://github.com/apache/flink/pull/14429


   ## What is the purpose of the change
   
   *Separate the implementation of StreamExecWatermarkAssigner*
   
   
   ## Brief change log
   
     - *Introduce StreamPhysicalWatermarkAssigner, and make StreamExecWatermarkAssigner only extended from ExecNode*
   
   
   ## Verifying this change
   
   This change is a refactoring rework covered by existing tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14429: [FLINK-20623][table-planner-blink] Introduce StreamPhysicalWatermarkAssigner, and make StreamExecWatermarkAssigner only extended from ExecNode

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14429:
URL: https://github.com/apache/flink/pull/14429#issuecomment-748082234


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2480c4158f646cef362efb050fe60356c80bcd0c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11041",
       "triggerID" : "2480c4158f646cef362efb050fe60356c80bcd0c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2480c4158f646cef362efb050fe60356c80bcd0c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11041) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] godfreyhe commented on pull request #14429: [FLINK-20623][table-planner-blink] Introduce StreamPhysicalWatermarkAssigner, and make StreamExecWatermarkAssigner only extended from ExecNode

Posted by GitBox <gi...@apache.org>.
godfreyhe commented on pull request #14429:
URL: https://github.com/apache/flink/pull/14429#issuecomment-749315199


   I will resolve the conflicts offline and merge this pr


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14429: [FLINK-20623][table-planner-blink] Introduce StreamPhysicalWatermarkAssigner, and make StreamExecWatermarkAssigner only extended from ExecNode

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14429:
URL: https://github.com/apache/flink/pull/14429#issuecomment-748071704


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 2480c4158f646cef362efb050fe60356c80bcd0c (Fri Dec 18 13:00:14 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-20623).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14429: [FLINK-20623][table-planner-blink] Introduce StreamPhysicalWatermarkAssigner, and make StreamExecWatermarkAssigner only extended from ExecNode

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14429:
URL: https://github.com/apache/flink/pull/14429#issuecomment-748082234


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2480c4158f646cef362efb050fe60356c80bcd0c",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11041",
       "triggerID" : "2480c4158f646cef362efb050fe60356c80bcd0c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2480c4158f646cef362efb050fe60356c80bcd0c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11041) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] godfreyhe commented on pull request #14429: [FLINK-20623][table-planner-blink] Introduce StreamPhysicalWatermarkAssigner, and make StreamExecWatermarkAssigner only extended from ExecNode

Posted by GitBox <gi...@apache.org>.
godfreyhe commented on pull request #14429:
URL: https://github.com/apache/flink/pull/14429#issuecomment-748965166


   I will merge this once the test is success


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14429: [FLINK-20623][table-planner-blink] Introduce StreamPhysicalWatermarkAssigner, and make StreamExecWatermarkAssigner only extended from ExecNode

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14429:
URL: https://github.com/apache/flink/pull/14429#issuecomment-748082234


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2480c4158f646cef362efb050fe60356c80bcd0c",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11041",
       "triggerID" : "2480c4158f646cef362efb050fe60356c80bcd0c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f7f013bd45f3048016c9be050eff5a92373b1a5f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f7f013bd45f3048016c9be050eff5a92373b1a5f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2480c4158f646cef362efb050fe60356c80bcd0c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11041) 
   * f7f013bd45f3048016c9be050eff5a92373b1a5f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] godfreyhe closed pull request #14429: [FLINK-20623][table-planner-blink] Introduce StreamPhysicalWatermarkAssigner, and make StreamExecWatermarkAssigner only extended from ExecNode

Posted by GitBox <gi...@apache.org>.
godfreyhe closed pull request #14429:
URL: https://github.com/apache/flink/pull/14429


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14429: [FLINK-20623][table-planner-blink] Introduce StreamPhysicalWatermarkAssigner, and make StreamExecWatermarkAssigner only extended from ExecNode

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14429:
URL: https://github.com/apache/flink/pull/14429#issuecomment-748082234


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2480c4158f646cef362efb050fe60356c80bcd0c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11041",
       "triggerID" : "2480c4158f646cef362efb050fe60356c80bcd0c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f7f013bd45f3048016c9be050eff5a92373b1a5f",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11124",
       "triggerID" : "f7f013bd45f3048016c9be050eff5a92373b1a5f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f7f013bd45f3048016c9be050eff5a92373b1a5f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11124) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14429: [FLINK-20623][table-planner-blink] Introduce StreamPhysicalWatermarkAssigner, and make StreamExecWatermarkAssigner only extended from ExecNode

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14429:
URL: https://github.com/apache/flink/pull/14429#issuecomment-748082234


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2480c4158f646cef362efb050fe60356c80bcd0c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2480c4158f646cef362efb050fe60356c80bcd0c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2480c4158f646cef362efb050fe60356c80bcd0c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14429: [FLINK-20623][table-planner-blink] Introduce StreamPhysicalWatermarkAssigner, and make StreamExecWatermarkAssigner only extended from ExecNode

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14429:
URL: https://github.com/apache/flink/pull/14429#issuecomment-748082234


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2480c4158f646cef362efb050fe60356c80bcd0c",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11041",
       "triggerID" : "2480c4158f646cef362efb050fe60356c80bcd0c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f7f013bd45f3048016c9be050eff5a92373b1a5f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11124",
       "triggerID" : "f7f013bd45f3048016c9be050eff5a92373b1a5f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2480c4158f646cef362efb050fe60356c80bcd0c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11041) 
   * f7f013bd45f3048016c9be050eff5a92373b1a5f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11124) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org