You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2023/05/26 11:02:55 UTC
[GitHub] [spark] panbingkun opened a new pull request, #41331: [SPARK-43808][SQL][TESTS] Use `checkError()` to check `Exception` in `SQLViewTestSuite`
panbingkun opened a new pull request, #41331:
URL: https://github.com/apache/spark/pull/41331
### What changes were proposed in this pull request?
The pr aims to use `checkError()` to check `Exception` in `SQLViewTestSuite`.
### Why are the changes needed?
Migration on checkError() will make the tests independent from the text of error messages.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
- By running the modified test suites:
$ build/sbt "test:testOnly *.LocalTempViewTestSuite"
$ build/sbt "test:testOnly *.GlobalTempViewTestSuite"
$ build/sbt "test:testOnly *.PersistedViewTestSuite"
- Pass GA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #41331: [SPARK-43808][SQL][TESTS] Use `checkError()` to check `Exception` in `SQLViewTestSuite`
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #41331: [SPARK-43808][SQL][TESTS] Use `checkError()` to check `Exception` in `SQLViewTestSuite`
URL: https://github.com/apache/spark/pull/41331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #41331: [SPARK-43808][SQL][TESTS] Use `checkError()` to check `Exception` in `SQLViewTestSuite`
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #41331:
URL: https://github.com/apache/spark/pull/41331#issuecomment-1564736382
+1, LGTM. Merging to master.
Thank you, @panbingkun.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #41331: [SPARK-43808][SQL][TESTS] Use `checkError()` to check `Exception` in `SQLViewTestSuite`
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #41331:
URL: https://github.com/apache/spark/pull/41331#issuecomment-1564645453
cc @MaxGekk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org