You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by msiegel07 <gi...@git.apache.org> on 2014/11/26 19:46:11 UTC
[GitHub] storm pull request: Specify UI/Jetty interface to bind to (ui.host...
GitHub user msiegel07 opened a pull request:
https://github.com/apache/storm/pull/329
Specify UI/Jetty interface to bind to (ui.host)
Provides the ability to specify the Jetty host configuration as 'ui,host'. Defaults to '0.0.0.0' to bind to all interfaces.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/msiegel07/storm 0.9.3-branch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/329.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #329
----
commit d3efb97a1722d9b9bdd7b92c508ac607cb18a7c3
Author: Matt Siegel <ma...@solers.com>
Date: 2014-11-26T18:37:37Z
Specify UI/Jetty interface to bind to (ui.host)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-575] Specify UI/Jetty interface to bind...
Posted by msiegel07 <gi...@git.apache.org>.
Github user msiegel07 commented on the pull request:
https://github.com/apache/storm/pull/329#issuecomment-65104657
Should I resubmit a pull request against master? (and close this one?)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-575] Specify UI/Jetty interface to bind...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/329#issuecomment-64722744
This looks fine to me +1. My only concern is that this pull request is against 0.9.3-branch and not master. I will leave it up to @ptgoetz if he wants to have the 0.9.3 line accept new features and continue on. Otherwise we really should just have this point to master.
The upmerge to master is fairly straight forward but there was one conflict, that was not trivial.
```
diff --git a/storm-core/src/clj/backtype/storm/ui/core.clj b/storm-core/src/clj/backtype/storm/ui/core.clj
index 3dc7396..c272cf0 100644
--- a/storm-core/src/clj/backtype/storm/ui/core.clj
+++ b/storm-core/src/clj/backtype/storm/ui/core.clj
@@ -978,6 +978,7 @@
filters-confs [{:filter-class (conf UI-FILTER)
:filter-params (conf UI-FILTER-PARAMS)}]]
(storm-run-jetty {:port (conf UI-PORT)
+ :host (conf UI-HOST)
:configurator (fn [server]
(doseq [connector (.getConnectors server)]
(.setRequestHeaderSize connector header-buffer-size))
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-575] Specify UI/Jetty interface to bind...
Posted by msiegel07 <gi...@git.apache.org>.
Github user msiegel07 commented on the pull request:
https://github.com/apache/storm/pull/329#issuecomment-65106026
Sorry, deleting the branch and closing it was not on purpose. I'll resubmit against master since that was clearly the correct thing to do from the beginning anyway
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-575] Specify UI/Jetty interface to bind...
Posted by Parth-Brahmbhatt <gi...@git.apache.org>.
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/329#issuecomment-64726991
+1 (nonbinding)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-575] Specify UI/Jetty interface to bind...
Posted by msiegel07 <gi...@git.apache.org>.
Github user msiegel07 commented on the pull request:
https://github.com/apache/storm/pull/329#issuecomment-64734276
Do you want me to do a pull request against master? Close this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Specify UI/Jetty interface to bind to (ui.host...
Posted by msiegel07 <gi...@git.apache.org>.
Github user msiegel07 commented on the pull request:
https://github.com/apache/storm/pull/329#issuecomment-64694837
Submitted STORM-575.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Specify UI/Jetty interface to bind to (ui.host...
Posted by Parth-Brahmbhatt <gi...@git.apache.org>.
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/329#issuecomment-64695033
@msiegel07 can you also add STORM-575: at the beginning of your commit message so it correctly links to the jira.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Specify UI/Jetty interface to bind to (ui.host...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/329#issuecomment-64693204
@msiegel07 can you please open a JIRA. thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-575] Specify UI/Jetty interface to bind...
Posted by msiegel07 <gi...@git.apache.org>.
Github user msiegel07 closed the pull request at:
https://github.com/apache/storm/pull/329
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-575] Specify UI/Jetty interface to bind...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/329#issuecomment-64720994
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---