You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Virag Kothari <vi...@yahoo-inc.com> on 2013/03/02 01:13:01 UTC
Review Request: OOZIE-1235: Client API for retrieving topic and jms
connection related details
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9709/
-----------------------------------------------------------
Review request for oozie.
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1235
This addresses bug OOZIE-1235.
https://issues.apache.org/jira/browse/OOZIE-1235
Diffs
-----
trunk/client/src/main/java/org/apache/oozie/client/JMSConnectionInfo.java PRE-CREATION
trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1451689
trunk/client/src/main/java/org/apache/oozie/client/rest/JsonTags.java 1451689
trunk/client/src/main/java/org/apache/oozie/client/rest/JsonToBean.java 1451689
trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1451689
trunk/client/src/test/java/org/apache/oozie/client/rest/TestJsonToBean.java 1451689
trunk/core/src/main/java/org/apache/oozie/BaseEngine.java 1451689
trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1451689
trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1451689
trunk/core/src/main/java/org/apache/oozie/DagEngine.java 1451689
trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1451689
trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1451689
trunk/core/src/main/java/org/apache/oozie/client/rest/JMSConnectionInfoBean.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/command/JMSInfoXCommand.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobGetForUserJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetForUserJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/jms/DefaultJMSServerInfo.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/jms/JMSServerInfo.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java 1451689
trunk/core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 1451689
trunk/core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 1451689
trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1451689
trunk/core/src/test/java/org/apache/oozie/command/TestJMSInfoXCommand.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/jms/TestJMSServerInfo.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/servlet/MockDagEngineService.java 1451689
trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 1451689
Diff: https://reviews.apache.org/r/9709/diff/
Testing
-------
Thanks,
Virag Kothari
Re: Review Request: OOZIE-1235: Client API for retrieving topic and jms
connection related details
Posted by Virag Kothari <vi...@yahoo-inc.com>.
> On March 22, 2013, 2:37 a.m., Mohammad Islam wrote:
> > trunk/core/src/main/java/org/apache/oozie/client/rest/JMSConnectionInfoBean.java, line 38
> > <https://reviews.apache.org/r/9709/diff/2/?file=272988#file272988line38>
> >
> > Is the parameter tzId required? no usage.
Not required. Will remove. Result of copying code from other bean.
> On March 22, 2013, 2:37 a.m., Mohammad Islam wrote:
> > trunk/core/src/main/java/org/apache/oozie/jms/DefaultJMSServerInfo.java, line 35
> > <https://reviews.apache.org/r/9709/diff/2/?file=272993#file272993line35>
> >
> > if (jmsTopicService != null)
> > just for the safety..
kk
> On March 22, 2013, 2:37 a.m., Mohammad Islam wrote:
> > trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java, line 87
> > <https://reviews.apache.org/r/9709/diff/2/?file=272996#file272996line87>
> >
> > take out 'not' pls
kk
> On March 22, 2013, 2:37 a.m., Mohammad Islam wrote:
> > trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java, line 139
> > <https://reviews.apache.org/r/9709/diff/2/?file=272996#file272996line139>
> >
> > is it "-B_" not "_B@"?
For bundle, its -B_
> On March 22, 2013, 2:37 a.m., Mohammad Islam wrote:
> > trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java, line 160
> > <https://reviews.apache.org/r/9709/diff/2/?file=272996#file272996line160>
> >
> > why do we need this type of topic?
Had an offline discussion with Mohammad.
jobId is unique and user.jobId is not beneficial in any way. So will remove
> On March 22, 2013, 2:37 a.m., Mohammad Islam wrote:
> > trunk/core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java, line 212
> > <https://reviews.apache.org/r/9709/diff/2/?file=272998#file272998line212>
> >
> > No sure we need it for 'v0'. Also not sure if we need new 'v2'. because this change in REST API.
> > Open question..
Based on offline discussion with Mohammad, things might break if newer client is talking to an older server. But the impact is minimal for breaking such a comptability. So we can just keep in v1. For v0, we are only throwing an Exception. So that is fine.
> On March 22, 2013, 2:37 a.m., Mohammad Islam wrote:
> > trunk/core/src/main/resources/oozie-default.xml, line 149
> > <https://reviews.apache.org/r/9709/diff/2/?file=273000#file273000line149>
> >
> > pls takeout all RED color
kk
> On March 22, 2013, 2:37 a.m., Mohammad Islam wrote:
> > trunk/core/src/main/resources/oozie-default.xml, line 158
> > <https://reviews.apache.org/r/9709/diff/2/?file=273000#file273000line158>
> >
> > Description might need to be changed based on "user.jobid"
- Virag
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9709/#review18233
-----------------------------------------------------------
On March 21, 2013, 7:40 p.m., Virag Kothari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9709/
> -----------------------------------------------------------
>
> (Updated March 21, 2013, 7:40 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1235
>
>
> This addresses bug OOZIE-1235.
> https://issues.apache.org/jira/browse/OOZIE-1235
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/JMSConnectionInfo.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1459407
> trunk/client/src/main/java/org/apache/oozie/client/rest/JsonTags.java 1459407
> trunk/client/src/main/java/org/apache/oozie/client/rest/JsonToBean.java 1459407
> trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1459407
> trunk/client/src/test/java/org/apache/oozie/client/rest/TestJsonToBean.java 1459407
> trunk/core/src/main/java/org/apache/oozie/BaseEngine.java 1459407
> trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1459407
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1459407
> trunk/core/src/main/java/org/apache/oozie/DagEngine.java 1459407
> trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1459407
> trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1459407
> trunk/core/src/main/java/org/apache/oozie/client/rest/JMSConnectionInfoBean.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/command/JMSInfoXCommand.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobGetForUserJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetForUserJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/jms/DefaultJMSServerInfo.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/jms/JMSServerInfo.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java 1459407
> trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 1459407
> trunk/core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 1459407
> trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1459407
> trunk/core/src/main/resources/oozie-default.xml 1459407
> trunk/core/src/test/java/org/apache/oozie/command/TestJMSInfoXCommand.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/jms/TestJMSServerInfo.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestJMSTopicService.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/servlet/MockDagEngineService.java 1459407
> trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 1459407
>
> Diff: https://reviews.apache.org/r/9709/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Virag Kothari
>
>
Re: Review Request: OOZIE-1235: Client API for retrieving topic and jms
connection related details
Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9709/#review18233
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/client/rest/JMSConnectionInfoBean.java
<https://reviews.apache.org/r/9709/#comment38436>
Is the parameter tzId required? no usage.
trunk/core/src/main/java/org/apache/oozie/jms/DefaultJMSServerInfo.java
<https://reviews.apache.org/r/9709/#comment38437>
if (jmsTopicService != null)
just for the safety..
trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java
<https://reviews.apache.org/r/9709/#comment38438>
take out 'not' pls
trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java
<https://reviews.apache.org/r/9709/#comment38439>
take out this.
trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java
<https://reviews.apache.org/r/9709/#comment38440>
is it "-B_" not "_B@"?
trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java
<https://reviews.apache.org/r/9709/#comment38441>
why do we need this type of topic?
trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java
<https://reviews.apache.org/r/9709/#comment38442>
same
trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java
<https://reviews.apache.org/r/9709/#comment38443>
same
trunk/core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java
<https://reviews.apache.org/r/9709/#comment38444>
No sure we need it for 'v0'. Also not sure if we need new 'v2'. because this change in REST API.
Open question..
trunk/core/src/main/resources/oozie-default.xml
<https://reviews.apache.org/r/9709/#comment38445>
pls takeout all RED color
trunk/core/src/main/resources/oozie-default.xml
<https://reviews.apache.org/r/9709/#comment38446>
Description might need to be changed based on "user.jobid"
- Mohammad Islam
On March 21, 2013, 7:40 p.m., Virag Kothari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9709/
> -----------------------------------------------------------
>
> (Updated March 21, 2013, 7:40 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1235
>
>
> This addresses bug OOZIE-1235.
> https://issues.apache.org/jira/browse/OOZIE-1235
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/JMSConnectionInfo.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1459407
> trunk/client/src/main/java/org/apache/oozie/client/rest/JsonTags.java 1459407
> trunk/client/src/main/java/org/apache/oozie/client/rest/JsonToBean.java 1459407
> trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1459407
> trunk/client/src/test/java/org/apache/oozie/client/rest/TestJsonToBean.java 1459407
> trunk/core/src/main/java/org/apache/oozie/BaseEngine.java 1459407
> trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1459407
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1459407
> trunk/core/src/main/java/org/apache/oozie/DagEngine.java 1459407
> trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1459407
> trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1459407
> trunk/core/src/main/java/org/apache/oozie/client/rest/JMSConnectionInfoBean.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/command/JMSInfoXCommand.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobGetForUserJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetForUserJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/jms/DefaultJMSServerInfo.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/jms/JMSServerInfo.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java 1459407
> trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 1459407
> trunk/core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 1459407
> trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1459407
> trunk/core/src/main/resources/oozie-default.xml 1459407
> trunk/core/src/test/java/org/apache/oozie/command/TestJMSInfoXCommand.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/jms/TestJMSServerInfo.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestJMSTopicService.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/servlet/MockDagEngineService.java 1459407
> trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 1459407
>
> Diff: https://reviews.apache.org/r/9709/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Virag Kothari
>
>
Re: Review Request: OOZIE-1235: Client API for retrieving topic and jms
connection related details
Posted by Virag Kothari <vi...@yahoo-inc.com>.
> On April 8, 2013, 7:14 p.m., Mona Chitnis wrote:
> > trunk/core/src/main/java/org/apache/oozie/client/rest/JMSConnectionInfoBean.java, line 26
> > <https://reviews.apache.org/r/9709/diff/3/?file=274003#file274003line26>
> >
> > Is this class corresponding to a DB table? I think the norm we follow is 'bean' corresponds to persistence
Not necessariy persisted to db, but nything that can be serialized and later constructed back will be a bean. So this will be a bean as it is converted to json and then can later be converted back to java object
> On April 8, 2013, 7:14 p.m., Mona Chitnis wrote:
> > trunk/core/src/main/java/org/apache/oozie/command/JMSInfoXCommand.java, line 54
> > <https://reviews.apache.org/r/9709/diff/3/?file=274004#file274004line54>
> >
> > check for NPE, or maybe you are accounting for all exceptions in catch block - then never mind
JMSServerInfo cannot be null. So NPE unlikely
> On April 8, 2013, 7:14 p.m., Mona Chitnis wrote:
> > trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java, line 136
> > <https://reviews.apache.org/r/9709/diff/3/?file=274011#file274011line136>
> >
> > how come for bundle action ids, its underscore and the rest is '@'?
That is a mystery to me too :)
- Virag
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9709/#review18790
-----------------------------------------------------------
On March 23, 2013, 1:32 a.m., Virag Kothari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9709/
> -----------------------------------------------------------
>
> (Updated March 23, 2013, 1:32 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1235
>
>
> This addresses bug OOZIE-1235.
> https://issues.apache.org/jira/browse/OOZIE-1235
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/JMSConnectionInfo.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1459407
> trunk/client/src/main/java/org/apache/oozie/client/rest/JsonTags.java 1459407
> trunk/client/src/main/java/org/apache/oozie/client/rest/JsonToBean.java 1459407
> trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1459407
> trunk/client/src/test/java/org/apache/oozie/client/rest/TestJsonToBean.java 1459407
> trunk/core/src/main/java/org/apache/oozie/BaseEngine.java 1459407
> trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1459407
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1459407
> trunk/core/src/main/java/org/apache/oozie/DagEngine.java 1459407
> trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1459407
> trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1459407
> trunk/core/src/main/java/org/apache/oozie/client/rest/JMSConnectionInfoBean.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/command/JMSInfoXCommand.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobGetForUserJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetForUserJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/jms/DefaultJMSServerInfo.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/jms/JMSServerInfo.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java 1459407
> trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 1459407
> trunk/core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 1459407
> trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1459407
> trunk/core/src/main/resources/oozie-default.xml 1459407
> trunk/core/src/test/java/org/apache/oozie/command/TestJMSInfoXCommand.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/jms/TestJMSServerInfo.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestJMSTopicService.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/servlet/MockDagEngineService.java 1459407
> trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 1459407
>
> Diff: https://reviews.apache.org/r/9709/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Virag Kothari
>
>
Re: Review Request: OOZIE-1235: Client API for retrieving topic and jms
connection related details
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9709/#review18790
-----------------------------------------------------------
trunk/client/src/main/java/org/apache/oozie/client/rest/JsonTags.java
<https://reviews.apache.org/r/9709/#comment39224>
camel case is preferable for readability
trunk/core/src/main/java/org/apache/oozie/BaseEngine.java
<https://reviews.apache.org/r/9709/#comment39225>
wrong javadoc for this method
trunk/core/src/main/java/org/apache/oozie/DagEngine.java
<https://reviews.apache.org/r/9709/#comment39226>
this file only has unused import changes. remove from patch
trunk/core/src/main/java/org/apache/oozie/client/rest/JMSConnectionInfoBean.java
<https://reviews.apache.org/r/9709/#comment39228>
Is this class corresponding to a DB table? I think the norm we follow is 'bean' corresponds to persistence
trunk/core/src/main/java/org/apache/oozie/command/JMSInfoXCommand.java
<https://reviews.apache.org/r/9709/#comment39227>
check for NPE, or maybe you are accounting for all exceptions in catch block - then never mind
trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java
<https://reviews.apache.org/r/9709/#comment39229>
also include the property name, say split[0], in the error message so user knows immediately what to correct
trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java
<https://reviews.apache.org/r/9709/#comment39230>
how come for bundle action ids, its underscore and the rest is '@'?
- Mona Chitnis
On March 23, 2013, 1:32 a.m., Virag Kothari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9709/
> -----------------------------------------------------------
>
> (Updated March 23, 2013, 1:32 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1235
>
>
> This addresses bug OOZIE-1235.
> https://issues.apache.org/jira/browse/OOZIE-1235
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/JMSConnectionInfo.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1459407
> trunk/client/src/main/java/org/apache/oozie/client/rest/JsonTags.java 1459407
> trunk/client/src/main/java/org/apache/oozie/client/rest/JsonToBean.java 1459407
> trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1459407
> trunk/client/src/test/java/org/apache/oozie/client/rest/TestJsonToBean.java 1459407
> trunk/core/src/main/java/org/apache/oozie/BaseEngine.java 1459407
> trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1459407
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1459407
> trunk/core/src/main/java/org/apache/oozie/DagEngine.java 1459407
> trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1459407
> trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1459407
> trunk/core/src/main/java/org/apache/oozie/client/rest/JMSConnectionInfoBean.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/command/JMSInfoXCommand.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobGetForUserJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetForUserJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/jms/DefaultJMSServerInfo.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/jms/JMSServerInfo.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java 1459407
> trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 1459407
> trunk/core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 1459407
> trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1459407
> trunk/core/src/main/resources/oozie-default.xml 1459407
> trunk/core/src/test/java/org/apache/oozie/command/TestJMSInfoXCommand.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/jms/TestJMSServerInfo.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestJMSTopicService.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/servlet/MockDagEngineService.java 1459407
> trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 1459407
>
> Diff: https://reviews.apache.org/r/9709/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Virag Kothari
>
>
Re: Review Request: OOZIE-1235: Client API for retrieving topic and jms
connection related details
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9709/#review19086
-----------------------------------------------------------
+1. Good tests for JMSTopicService!
- Mona Chitnis
On April 10, 2013, 7:09 a.m., Virag Kothari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9709/
> -----------------------------------------------------------
>
> (Updated April 10, 2013, 7:09 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1235
>
>
> This addresses bug OOZIE-1235.
> https://issues.apache.org/jira/browse/OOZIE-1235
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1466337
> trunk/client/src/main/java/org/apache/oozie/client/JMSConnectionInfo.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1466337
> trunk/client/src/main/java/org/apache/oozie/client/rest/JsonTags.java 1466337
> trunk/client/src/main/java/org/apache/oozie/client/rest/JsonToBean.java 1466337
> trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1466337
> trunk/client/src/test/java/org/apache/oozie/client/rest/TestJsonToBean.java 1466337
> trunk/core/src/main/java/org/apache/oozie/BaseEngine.java 1466337
> trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1466337
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1466337
> trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1466337
> trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1466337
> trunk/core/src/main/java/org/apache/oozie/client/rest/JMSConnectionInfoBean.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/command/JMSInfoXCommand.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobGetForUserJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetForUserJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/jms/DefaultJMSServerInfo.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/jms/JMSServerInfo.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java 1466337
> trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 1466337
> trunk/core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 1466337
> trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1466337
> trunk/core/src/main/resources/oozie-default.xml 1466337
> trunk/core/src/test/java/org/apache/oozie/command/TestJMSInfoXCommand.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/jms/TestJMSServerInfo.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestJMSTopicService.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/servlet/MockDagEngineService.java 1466337
> trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 1466337
>
> Diff: https://reviews.apache.org/r/9709/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Virag Kothari
>
>
Re: Review Request: OOZIE-1235: Client API for retrieving topic and jms
connection related details
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9709/
-----------------------------------------------------------
(Updated April 10, 2013, 7:09 a.m.)
Review request for oozie.
Changes
-------
Changes:
Added CLI api to retrieve jms connection info details
Did end to end run to test that CLI works
Addressed Mona's comments
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1235
This addresses bug OOZIE-1235.
https://issues.apache.org/jira/browse/OOZIE-1235
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1466337
trunk/client/src/main/java/org/apache/oozie/client/JMSConnectionInfo.java PRE-CREATION
trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1466337
trunk/client/src/main/java/org/apache/oozie/client/rest/JsonTags.java 1466337
trunk/client/src/main/java/org/apache/oozie/client/rest/JsonToBean.java 1466337
trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1466337
trunk/client/src/test/java/org/apache/oozie/client/rest/TestJsonToBean.java 1466337
trunk/core/src/main/java/org/apache/oozie/BaseEngine.java 1466337
trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1466337
trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1466337
trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1466337
trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1466337
trunk/core/src/main/java/org/apache/oozie/client/rest/JMSConnectionInfoBean.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/command/JMSInfoXCommand.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobGetForUserJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetForUserJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/jms/DefaultJMSServerInfo.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/jms/JMSServerInfo.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java 1466337
trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 1466337
trunk/core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 1466337
trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1466337
trunk/core/src/main/resources/oozie-default.xml 1466337
trunk/core/src/test/java/org/apache/oozie/command/TestJMSInfoXCommand.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/jms/TestJMSServerInfo.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/service/TestJMSTopicService.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/servlet/MockDagEngineService.java 1466337
trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 1466337
Diff: https://reviews.apache.org/r/9709/diff/
Testing
-------
Thanks,
Virag Kothari
Re: Review Request: OOZIE-1235: Client API for retrieving topic and jms
connection related details
Posted by Virag Kothari <vi...@yahoo-inc.com>.
> On April 8, 2013, 7:47 p.m., Mona Chitnis wrote:
> > trunk/client/src/main/java/org/apache/oozie/client/rest/JsonToBean.java, line 255
> > <https://reviews.apache.org/r/9709/diff/3/?file=273994#file273994line255>
> >
> > this patch needs to be rebased with updated trunk. I see more if-else clauses in this function in addition to those here
You seem to have seen something else. This file hasn't been modified since quite a while.
- Virag
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9709/#review18792
-----------------------------------------------------------
On March 23, 2013, 1:32 a.m., Virag Kothari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9709/
> -----------------------------------------------------------
>
> (Updated March 23, 2013, 1:32 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1235
>
>
> This addresses bug OOZIE-1235.
> https://issues.apache.org/jira/browse/OOZIE-1235
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/JMSConnectionInfo.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1459407
> trunk/client/src/main/java/org/apache/oozie/client/rest/JsonTags.java 1459407
> trunk/client/src/main/java/org/apache/oozie/client/rest/JsonToBean.java 1459407
> trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1459407
> trunk/client/src/test/java/org/apache/oozie/client/rest/TestJsonToBean.java 1459407
> trunk/core/src/main/java/org/apache/oozie/BaseEngine.java 1459407
> trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1459407
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1459407
> trunk/core/src/main/java/org/apache/oozie/DagEngine.java 1459407
> trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1459407
> trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1459407
> trunk/core/src/main/java/org/apache/oozie/client/rest/JMSConnectionInfoBean.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/command/JMSInfoXCommand.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobGetForUserJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetForUserJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/jms/DefaultJMSServerInfo.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/jms/JMSServerInfo.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java 1459407
> trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 1459407
> trunk/core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 1459407
> trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1459407
> trunk/core/src/main/resources/oozie-default.xml 1459407
> trunk/core/src/test/java/org/apache/oozie/command/TestJMSInfoXCommand.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/jms/TestJMSServerInfo.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestJMSTopicService.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/servlet/MockDagEngineService.java 1459407
> trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 1459407
>
> Diff: https://reviews.apache.org/r/9709/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Virag Kothari
>
>
Re: Review Request: OOZIE-1235: Client API for retrieving topic and jms
connection related details
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9709/#review18792
-----------------------------------------------------------
trunk/client/src/main/java/org/apache/oozie/client/rest/JsonToBean.java
<https://reviews.apache.org/r/9709/#comment39231>
this patch needs to be rebased with updated trunk. I see more if-else clauses in this function in addition to those here
- Mona Chitnis
On March 23, 2013, 1:32 a.m., Virag Kothari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9709/
> -----------------------------------------------------------
>
> (Updated March 23, 2013, 1:32 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1235
>
>
> This addresses bug OOZIE-1235.
> https://issues.apache.org/jira/browse/OOZIE-1235
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/JMSConnectionInfo.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1459407
> trunk/client/src/main/java/org/apache/oozie/client/rest/JsonTags.java 1459407
> trunk/client/src/main/java/org/apache/oozie/client/rest/JsonToBean.java 1459407
> trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1459407
> trunk/client/src/test/java/org/apache/oozie/client/rest/TestJsonToBean.java 1459407
> trunk/core/src/main/java/org/apache/oozie/BaseEngine.java 1459407
> trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1459407
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1459407
> trunk/core/src/main/java/org/apache/oozie/DagEngine.java 1459407
> trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1459407
> trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1459407
> trunk/core/src/main/java/org/apache/oozie/client/rest/JMSConnectionInfoBean.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/command/JMSInfoXCommand.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobGetForUserJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetForUserJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/jms/DefaultJMSServerInfo.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/jms/JMSServerInfo.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java 1459407
> trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 1459407
> trunk/core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 1459407
> trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1459407
> trunk/core/src/main/resources/oozie-default.xml 1459407
> trunk/core/src/test/java/org/apache/oozie/command/TestJMSInfoXCommand.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/jms/TestJMSServerInfo.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestJMSTopicService.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/servlet/MockDagEngineService.java 1459407
> trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 1459407
>
> Diff: https://reviews.apache.org/r/9709/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Virag Kothari
>
>
Re: Review Request: OOZIE-1235: Client API for retrieving topic and jms
connection related details
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9709/
-----------------------------------------------------------
(Updated March 23, 2013, 1:32 a.m.)
Review request for oozie.
Changes
-------
Updated based on Mohammad's comments.
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1235
This addresses bug OOZIE-1235.
https://issues.apache.org/jira/browse/OOZIE-1235
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/client/JMSConnectionInfo.java PRE-CREATION
trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1459407
trunk/client/src/main/java/org/apache/oozie/client/rest/JsonTags.java 1459407
trunk/client/src/main/java/org/apache/oozie/client/rest/JsonToBean.java 1459407
trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1459407
trunk/client/src/test/java/org/apache/oozie/client/rest/TestJsonToBean.java 1459407
trunk/core/src/main/java/org/apache/oozie/BaseEngine.java 1459407
trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1459407
trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1459407
trunk/core/src/main/java/org/apache/oozie/DagEngine.java 1459407
trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1459407
trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1459407
trunk/core/src/main/java/org/apache/oozie/client/rest/JMSConnectionInfoBean.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/command/JMSInfoXCommand.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobGetForUserJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetForUserJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/jms/DefaultJMSServerInfo.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/jms/JMSServerInfo.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java 1459407
trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 1459407
trunk/core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 1459407
trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1459407
trunk/core/src/main/resources/oozie-default.xml 1459407
trunk/core/src/test/java/org/apache/oozie/command/TestJMSInfoXCommand.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/jms/TestJMSServerInfo.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/service/TestJMSTopicService.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/servlet/MockDagEngineService.java 1459407
trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 1459407
Diff: https://reviews.apache.org/r/9709/diff/
Testing
-------
Thanks,
Virag Kothari
Re: Review Request: OOZIE-1235: Client API for retrieving topic and jms
connection related details
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9709/
-----------------------------------------------------------
(Updated March 21, 2013, 7:40 p.m.)
Review request for oozie.
Changes
-------
Based on comments in meetup, added a generic topic service which can allow topic to be variables like ${username}, ${jobId} or ${username}.${jobId}. Also it can be a fixed string like 'workflow, 'coord' etc.
Topics can also be specified at job level. For. e.g Topic name for workflow can be '${jobId}' and for coordinator it can be a fixed string 'coord'
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1235
This addresses bug OOZIE-1235.
https://issues.apache.org/jira/browse/OOZIE-1235
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/client/JMSConnectionInfo.java PRE-CREATION
trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1459407
trunk/client/src/main/java/org/apache/oozie/client/rest/JsonTags.java 1459407
trunk/client/src/main/java/org/apache/oozie/client/rest/JsonToBean.java 1459407
trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1459407
trunk/client/src/test/java/org/apache/oozie/client/rest/TestJsonToBean.java 1459407
trunk/core/src/main/java/org/apache/oozie/BaseEngine.java 1459407
trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1459407
trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1459407
trunk/core/src/main/java/org/apache/oozie/DagEngine.java 1459407
trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1459407
trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1459407
trunk/core/src/main/java/org/apache/oozie/client/rest/JMSConnectionInfoBean.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/command/JMSInfoXCommand.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobGetForUserJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetForUserJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/jms/DefaultJMSServerInfo.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/jms/JMSServerInfo.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java 1459407
trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 1459407
trunk/core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 1459407
trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1459407
trunk/core/src/main/resources/oozie-default.xml 1459407
trunk/core/src/test/java/org/apache/oozie/command/TestJMSInfoXCommand.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/jms/TestJMSServerInfo.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/service/TestJMSTopicService.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/servlet/MockDagEngineService.java 1459407
trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 1459407
Diff: https://reviews.apache.org/r/9709/diff/
Testing
-------
Thanks,
Virag Kothari