[GitHub] [fineract] ivan333m commented on issue #642: FINERACT-724 Upgrade Spring Boot, Spring and Spring Security to their latest stable version

[GitBox <gi...@apache.org>]

ivan333m commented on issue #642: FINERACT-724 Upgrade Spring Boot, Spring and Spring Security to their latest stable version
URL: https://github.com/apache/fineract/pull/642#issuecomment-552816934
 
 
   > @ivan333m thanks for your updates! I'll re-review as soon as I have more than a quick moment like now. (BTW @awasum @conradsp @awasum @Anh3h @vishwasbabu would you also like to review this, or shall I just go ahead and merge it when it Looks Good To Me? No stress, just checking if any interest from any of you. Specifically, there is some security related changes here which I would welcome more eyes on.)
   > 
   > On the last build, the `integrationTest` failed (only) below, will you have a look at that? If you suspect that it's some intermittent issue which you can not reproduce locally, then just rebase this PR so that a new build runs:
   > 
   > ```
   > org.apache.fineract.integrationtests.RecurringDepositTest > testRecurringDepositAccountWithPrematureClosureTypeTransferToSavings_WITH_HOLD_TAX FAILED
   > 
   >     java.lang.AssertionError at RecurringDepositTest.java:643
   > ```
   
   I can't reproduce the fail locally. So I have made a rebase. But build failed again. In logs I have found 
   `BUILD SUCCESSFUL in 18m 8s ` and a batch of deadlocks. It a little bit confusing. :) 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services