[GitHub] [arrow] edponce commented on pull request #11882: ARROW-9843: [C++] Implement Between ternary kernel

[GitBox <gi...@apache.org>]

edponce commented on pull request #11882:
URL: https://github.com/apache/arrow/pull/11882#issuecomment-1008355611


   @bkmgit For Python, you would only need to add bindings for `BetweenOptions` because the compute function is "binded" automatically (`call_function` mechanism). I suggest that you [`grep -R RoundOptions arrow/python/pyarrow/`](https://github.com/apache/arrow/tree/master/python/pyarrow) so you can see what are the things needed in Python to provide full support for `between` function. The following are main actions to complete for Python bindings:
   * [Cython header binding for options `pyarrow/includes/libarrow.pxd`](https://github.com/apache/arrow/blob/master/python/pyarrow/includes/libarrow.pxd#L1866-L1893) - Note that the enum is in global scope because it is used by `Round` and `RoundToMultiple`. In this case, `BetweenOptions` will be used by `Between` and `NotBetween`, so maybe it is wise in C++ to put `BetweenOptions` in global space now instead of in `NotBetween` PR.
   * [Cython/Python definitions for options `pyarrow/_compute.pyx`](https://github.com/apache/arrow/blob/master/python/pyarrow/_compute.pyx#L743-L776)
   * [Python test for `BetweenOptions`](https://github.com/apache/arrow/blob/master/python/pyarrow/tests/test_compute.py#L153)
   * [Python tests for compute function](https://github.com/apache/arrow/blob/master/python/pyarrow/tests/test_compute.py#L1409-L1472)
   * [Add function to Python docs](https://github.com/apache/arrow/blob/master/docs/source/python/api/compute.rst#comparisons)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org