[GitHub] [pinot] navina commented on a diff in pull request #10995: Extract record keys, headers and metadata from Pulsar sources

["navina (via GitHub)" <gi...@apache.org>]

navina commented on code in PR #10995:
URL: https://github.com/apache/pinot/pull/10995#discussion_r1256419574


##########
pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarConfig.java:
##########
@@ -46,6 +46,8 @@ public class PulsarConfig {
   private final String _authenticationToken;
   private final String _tlsTrustCertsFilePath;
   private final boolean _enableKeyValueStitch;

Review Comment:
   Yeah. You can add `@Deprecated(since = "v0.13.* since pulsar support record key extraction")` 
   Might have to update documentation (if it exists) in the website



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org